From: Tom Tromey <tromey@redhat.com>
To: Michael Eager <eager@eagerm.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Multi-process + multi-arch: GDB
Date: Tue, 13 Nov 2012 20:50:00 -0000 [thread overview]
Message-ID: <87vcd95isk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <509E800E.9030702@eagerm.com> (Michael Eager's message of "Sat, 10 Nov 2012 08:25:50 -0800")
>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:
Michael> I'd recommend get_target_arch() rather than recasting
Michael> target_gdbarch from a variable to a function. There are other
Michael> get_target_* () functions and this would parallel that usage.
Michael> Another benefit: a more substantive change in the name is less
Michael> likely to be overlooked when adapting or backporting patches.
In this particular case, I don't think there are big problems that can
arise. target_gdbarch isn't used as a boolean, one of the major such
issues that can possibly arise. Other issues, I think, will be caught
by type-checking.
That said, I don't really care all that much about the name, and if
Pedro agrees I will rename it to something else.
Tom
next prev parent reply other threads:[~2012-11-13 20:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 1:52 Pedro Alves
2012-11-09 5:26 ` H.J. Lu
2012-11-09 10:07 ` Pedro Alves
2012-11-09 18:24 ` Tom Tromey
2012-11-09 18:30 ` Pedro Alves
2012-11-09 18:32 ` Tom Tromey
2012-11-09 18:47 ` Pedro Alves
2012-11-09 19:08 ` Tom Tromey
2012-11-09 19:14 ` Pedro Alves
2012-11-09 19:18 ` Tom Tromey
2012-11-09 19:40 ` should deprecated_target_gdbarch_select_hack be un-deprecated? Pedro Alves
2012-11-13 21:17 ` Tom Tromey
2012-11-14 13:54 ` Pedro Alves
2012-11-14 15:34 ` Tom Tromey
2012-11-10 16:25 ` [PATCH] Multi-process + multi-arch: GDB Michael Eager
2012-11-13 20:50 ` Tom Tromey [this message]
2012-11-14 13:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcd95isk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox