From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: should deprecated_target_gdbarch_select_hack be un-deprecated?
Date: Wed, 14 Nov 2012 13:54:00 -0000 [thread overview]
Message-ID: <50A3A28C.206@redhat.com> (raw)
In-Reply-To: <87haot5hjq.fsf@fleche.redhat.com>
On 11/13/2012 09:17 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Tom> Finally, I wonder whether deprecated_target_gdbarch_select_hack should
> Tom> be un-deprecated.
> [...]
>
> Pedro> Yes, I think so. We used to do nasty things with swapping out gdbarch's
> Pedro> fields, which I believe would be the gross "hack" part, but that is gone.
>
> How about this?
>
> I think my only real concern is the name I chose.
This is fine with me. My alternative suggestion would be "set_target_gdbarch",
as "set" is more traditional for a setter, which is what this function ended
up being.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-14 13:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 1:52 [PATCH] Multi-process + multi-arch: GDB Pedro Alves
2012-11-09 5:26 ` H.J. Lu
2012-11-09 10:07 ` Pedro Alves
2012-11-09 18:24 ` Tom Tromey
2012-11-09 18:30 ` Pedro Alves
2012-11-09 18:32 ` Tom Tromey
2012-11-09 18:47 ` Pedro Alves
2012-11-09 19:08 ` Tom Tromey
2012-11-09 19:14 ` Pedro Alves
2012-11-09 19:18 ` Tom Tromey
2012-11-09 19:40 ` should deprecated_target_gdbarch_select_hack be un-deprecated? Pedro Alves
2012-11-13 21:17 ` Tom Tromey
2012-11-14 13:54 ` Pedro Alves [this message]
2012-11-14 15:34 ` Tom Tromey
2012-11-10 16:25 ` [PATCH] Multi-process + multi-arch: GDB Michael Eager
2012-11-13 20:50 ` Tom Tromey
2012-11-14 13:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A3A28C.206@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox