From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 730 invoked by alias); 14 Nov 2012 13:54:35 -0000 Received: (qmail 720 invoked by uid 22791); 14 Nov 2012 13:54:34 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Nov 2012 13:54:23 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAEDsMPi007774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 14 Nov 2012 08:54:22 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAEDsLaI002778; Wed, 14 Nov 2012 08:54:21 -0500 Message-ID: <50A3A28C.206@redhat.com> Date: Wed, 14 Nov 2012 13:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: should deprecated_target_gdbarch_select_hack be un-deprecated? References: <20121109015149.13597.39322.stgit@brno.lan> <87lieaeisb.fsf@fleche.redhat.com> <509D4BCA.6020704@redhat.com> <87haoyeiev.fsf@fleche.redhat.com> <509D4FC9.2060208@redhat.com> <877gpuegsb.fsf@fleche.redhat.com> <509D5C1F.2010507@redhat.com> <87haot5hjq.fsf@fleche.redhat.com> In-Reply-To: <87haot5hjq.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00365.txt.bz2 On 11/13/2012 09:17 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Tom> Finally, I wonder whether deprecated_target_gdbarch_select_hack should > Tom> be un-deprecated. > [...] > > Pedro> Yes, I think so. We used to do nasty things with swapping out gdbarch's > Pedro> fields, which I believe would be the gross "hack" part, but that is gone. > > How about this? > > I think my only real concern is the name I chose. This is fine with me. My alternative suggestion would be "set_target_gdbarch", as "set" is more traditional for a setter, which is what this function ended up being. -- Pedro Alves