From: Michael Eager <eager@eagerm.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Multi-process + multi-arch: GDB
Date: Sat, 10 Nov 2012 16:25:00 -0000 [thread overview]
Message-ID: <509E800E.9030702@eagerm.com> (raw)
In-Reply-To: <877gpuegsb.fsf@fleche.redhat.com>
On 11/09/2012 11:07 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves<palves@redhat.com> writes:
> Pedro> I tried to follow the get_current_arch() precedent (was originally
> Pedro> current_gdbarch). Looking again, I messed up a bit, as get_target_arch()
> Pedro> would be even more in spirit.
>
> Pedro> But anyway is fine with me. You choose.;-)
>
> I picked 'target_gdbarch ()' just due to the long history of using this
> name.
I'd recommend get_target_arch() rather than recasting target_gdbarch
from a variable to a function. There are other get_target_* () functions
and this would parallel that usage. Another benefit: a more substantive
change in the name is less likely to be overlooked when adapting or backporting
patches.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2012-11-10 16:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 1:52 Pedro Alves
2012-11-09 5:26 ` H.J. Lu
2012-11-09 10:07 ` Pedro Alves
2012-11-09 18:24 ` Tom Tromey
2012-11-09 18:30 ` Pedro Alves
2012-11-09 18:32 ` Tom Tromey
2012-11-09 18:47 ` Pedro Alves
2012-11-09 19:08 ` Tom Tromey
2012-11-09 19:14 ` Pedro Alves
2012-11-09 19:18 ` Tom Tromey
2012-11-09 19:40 ` should deprecated_target_gdbarch_select_hack be un-deprecated? Pedro Alves
2012-11-13 21:17 ` Tom Tromey
2012-11-14 13:54 ` Pedro Alves
2012-11-14 15:34 ` Tom Tromey
2012-11-10 16:25 ` Michael Eager [this message]
2012-11-13 20:50 ` [PATCH] Multi-process + multi-arch: GDB Tom Tromey
2012-11-14 13:48 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509E800E.9030702@eagerm.com \
--to=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox