From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2037 invoked by alias); 10 Nov 2012 16:25:59 -0000 Received: (qmail 2024 invoked by uid 22791); 10 Nov 2012 16:25:55 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a43.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Nov 2012 16:25:51 +0000 Received: from homiemail-a43.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a43.g.dreamhost.com (Postfix) with ESMTP id B3D058C058; Sat, 10 Nov 2012 08:26:03 -0800 (PST) Received: from redwood.eagercon.com (c-50-148-128-197.hsd1.ca.comcast.net [50.148.128.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a43.g.dreamhost.com (Postfix) with ESMTPSA id 8CEDC8C057; Sat, 10 Nov 2012 08:26:03 -0800 (PST) Message-ID: <509E800E.9030702@eagerm.com> Date: Sat, 10 Nov 2012 16:25:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Tom Tromey CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] Multi-process + multi-arch: GDB References: <20121109015149.13597.39322.stgit@brno.lan> <87lieaeisb.fsf@fleche.redhat.com> <509D4BCA.6020704@redhat.com> <87haoyeiev.fsf@fleche.redhat.com> <509D4FC9.2060208@redhat.com> <877gpuegsb.fsf@fleche.redhat.com> In-Reply-To: <877gpuegsb.fsf@fleche.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00274.txt.bz2 On 11/09/2012 11:07 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > Pedro> I tried to follow the get_current_arch() precedent (was originally > Pedro> current_gdbarch). Looking again, I messed up a bit, as get_target_arch() > Pedro> would be even more in spirit. > > Pedro> But anyway is fine with me. You choose.;-) > > I picked 'target_gdbarch ()' just due to the long history of using this > name. I'd recommend get_target_arch() rather than recasting target_gdbarch from a variable to a function. There are other get_target_* () functions and this would parallel that usage. Another benefit: a more substantive change in the name is less likely to be overlooked when adapting or backporting patches. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077