From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5212 invoked by alias); 13 Nov 2012 20:50:58 -0000 Received: (qmail 5203 invoked by uid 22791); 13 Nov 2012 20:50:57 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Nov 2012 20:50:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qADKombf017918 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Nov 2012 15:50:48 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qADKoZIr028236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 13 Nov 2012 15:50:40 -0500 From: Tom Tromey To: Michael Eager Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] Multi-process + multi-arch: GDB References: <20121109015149.13597.39322.stgit@brno.lan> <87lieaeisb.fsf@fleche.redhat.com> <509D4BCA.6020704@redhat.com> <87haoyeiev.fsf@fleche.redhat.com> <509D4FC9.2060208@redhat.com> <877gpuegsb.fsf@fleche.redhat.com> <509E800E.9030702@eagerm.com> Date: Tue, 13 Nov 2012 20:50:00 -0000 In-Reply-To: <509E800E.9030702@eagerm.com> (Michael Eager's message of "Sat, 10 Nov 2012 08:25:50 -0800") Message-ID: <87vcd95isk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00343.txt.bz2 >>>>> "Michael" == Michael Eager writes: Michael> I'd recommend get_target_arch() rather than recasting Michael> target_gdbarch from a variable to a function. There are other Michael> get_target_* () functions and this would parallel that usage. Michael> Another benefit: a more substantive change in the name is less Michael> likely to be overlooked when adapting or backporting patches. In this particular case, I don't think there are big problems that can arise. target_gdbarch isn't used as a boolean, one of the major such issues that can possibly arise. Other issues, I think, will be caught by type-checking. That said, I don't really care all that much about the name, and if Pedro agrees I will rename it to something else. Tom