Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org,  Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command
Date: Thu, 25 Apr 2019 14:10:00 -0000	[thread overview]
Message-ID: <87tvemch0n.fsf@tromey.com> (raw)
In-Reply-To: <20190409025557.28846-1-simon.marchi@polymtl.ca> (Simon Marchi's	message of "Mon, 8 Apr 2019 22:55:57 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> When using the "start" command, GDB puts a temporary breakpoint on the
Simon> "main" symbol (we literally invoke the tbreak command).

[...]

Simon> The dummiest, most straightforward solution is to add -qualified when
Simon> invoking tbreak.  With this patch, "start" creates a single-location
Simon> breakpoint, as expected.

This seems like a good idea to me, with the possible caveat that it
should be tested for Rust and Ada main programs as well.  (Though
probably there are already test cases covering this...?)

thanks,
Tom


  parent reply	other threads:[~2019-04-25 14:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  2:56 Simon Marchi
2019-04-09 15:27 ` Pedro Alves
2019-04-09 16:19   ` Simon Marchi
2019-04-09 16:30     ` Pedro Alves
2019-04-09 16:37       ` Simon Marchi
2019-04-09 18:09 ` André Pönitz
2019-04-09 22:02   ` [PP?] " Simon Marchi
2019-04-10 18:22     ` André Pönitz
2019-04-25 14:10 ` Tom Tromey [this message]
     [not found]   ` <96f5e735-0cdd-8bcb-58cf-e3986a5e3d5d@efficios.com>
2019-04-25 15:52     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvemch0n.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox