From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126298 invoked by alias); 25 Apr 2019 14:10:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126289 invoked by uid 89); 25 Apr 2019 14:10:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:2019040, literally X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 14:10:36 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway32.websitewelcome.com (Postfix) with ESMTP id B1CFE8BC42 for ; Thu, 25 Apr 2019 09:10:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Jf57hJRMD2qH7Jf57hdifl; Thu, 25 Apr 2019 09:10:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s8cnTZ+VLbBUOuJc3GKBmkrBQ0CI9vbafedTgFfL02c=; b=Uv4w4xgYi2dUyGMLojYX4NJ4Cd X1s7APl3dTiDyEnPYwNwQwMyZ18llYz0pBV1c0cyX9gNEErhJ+e6R5hwfmHt+Llw98ZLWytydY+Rk LaWipm7ybCMn9OMHizYbQ3qCP; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:56030 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hJf57-000J0J-FP; Thu, 25 Apr 2019 09:10:33 -0500 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command References: <20190409025557.28846-1-simon.marchi@polymtl.ca> Date: Thu, 25 Apr 2019 14:10:00 -0000 In-Reply-To: <20190409025557.28846-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Mon, 8 Apr 2019 22:55:57 -0400") Message-ID: <87tvemch0n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00517.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> When using the "start" command, GDB puts a temporary breakpoint on the Simon> "main" symbol (we literally invoke the tbreak command). [...] Simon> The dummiest, most straightforward solution is to add -qualified when Simon> invoking tbreak. With this patch, "start" creates a single-location Simon> breakpoint, as expected. This seems like a good idea to me, with the possible caveat that it should be tested for Rust and Ada main programs as well. (Though probably there are already test cases covering this...?) thanks, Tom