Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@efficios.com>,
	Simon Marchi <simon.marchi@polymtl.ca>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command
Date: Tue, 09 Apr 2019 16:30:00 -0000	[thread overview]
Message-ID: <4f78ab22-013e-9dba-6c3d-18c6a680c9a9@redhat.com> (raw)
In-Reply-To: <e5e172dc-56e9-4469-d900-5affcf025824@efficios.com>

On 4/9/19 5:19 PM, Simon Marchi wrote:

> I had initially changed start.exp to test both C and C++, then decided to just
> keep C++ for simplicity.  But your point about coverage is good, so I've done
> as you suggested.
> 

Thanks.

> gdb/ChangeLog:
> 
> 	* infcmd.c (run_command_1): Pass -qualified to tbreak when usind
> 	the "start" command.

Typo "usind".

> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/start-cpp.exp: New file.
> 	* gdb.base/start-cpp.cc: New file.

Note start-cpp.cc wasn't included in this patch -- don't forget
to git add it.

Otherwise OK.

Thanks,
Pedro Alves


  reply	other threads:[~2019-04-09 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  2:56 Simon Marchi
2019-04-09 15:27 ` Pedro Alves
2019-04-09 16:19   ` Simon Marchi
2019-04-09 16:30     ` Pedro Alves [this message]
2019-04-09 16:37       ` Simon Marchi
2019-04-09 18:09 ` André Pönitz
2019-04-09 22:02   ` [PP?] " Simon Marchi
2019-04-10 18:22     ` André Pönitz
2019-04-25 14:10 ` Tom Tromey
     [not found]   ` <96f5e735-0cdd-8bcb-58cf-e3986a5e3d5d@efficios.com>
2019-04-25 15:52     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f78ab22-013e-9dba-6c3d-18c6a680c9a9@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox