From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-155241-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 79915 invoked by alias); 9 Apr 2019 16:30:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 79906 invoked by uid 89); 9 Apr 2019 16:30:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO: mail-wr1-f67.google.com
Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Apr 2019 16:30:57 +0000
Received: by mail-wr1-f67.google.com with SMTP id w1so21771281wrp.2        for <gdb-patches@sourceware.org>; Tue, 09 Apr 2019 09:30:56 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id z14sm51334917wrv.78.2019.04.09.09.30.54        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Tue, 09 Apr 2019 09:30:54 -0700 (PDT)
Subject: Re: [PATCH] Use -qualified flag when setting temporary breakpoint in start command
To: Simon Marchi <simon.marchi@efficios.com>, Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20190409025557.28846-1-simon.marchi@polymtl.ca> <cdd9058b-e6d4-e2f1-4a1e-399571e0d2d8@redhat.com> <e5e172dc-56e9-4469-d900-5affcf025824@efficios.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <4f78ab22-013e-9dba-6c3d-18c6a680c9a9@redhat.com>
Date: Tue, 09 Apr 2019 16:30:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <e5e172dc-56e9-4469-d900-5affcf025824@efficios.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-04/txt/msg00146.txt.bz2

On 4/9/19 5:19 PM, Simon Marchi wrote:

> I had initially changed start.exp to test both C and C++, then decided to just
> keep C++ for simplicity.  But your point about coverage is good, so I've done
> as you suggested.
> 

Thanks.

> gdb/ChangeLog:
> 
> 	* infcmd.c (run_command_1): Pass -qualified to tbreak when usind
> 	the "start" command.

Typo "usind".

> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/start-cpp.exp: New file.
> 	* gdb.base/start-cpp.cc: New file.

Note start-cpp.cc wasn't included in this patch -- don't forget
to git add it.

Otherwise OK.

Thanks,
Pedro Alves