Re: [PATCH] gdbserver: Fix build on MIPS

[Sergio Durigan Junior <sergiodj@sergiodj.net>]

On Wednesday, January 15 2025, Joel Brobecker wrote:

> Hi Sergio,

Hey Joel!

> On Wed, Jan 15, 2025 at 11:07:20PM -0500, Sergio Durigan Junior wrote:
>> On Wednesday, January 15 2025, Simon Marchi wrote:
>> 
>> > On 2025-01-15 20:10, Sergio Durigan Junior wrote:
>> >> Commit 3470a0e144df6c01f8479fa649f43aa907936e7e inadvertently broke
>> >> the build on MIPS because it's passing a non-existent "pid" argument
>> >> to "proc->for_each_thread".  This commit fixes the problem by removing
>> >> the argument from the call.
>> >> 
>> >> Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
>> >> ---
>> >>  gdbserver/linux-mips-low.cc | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >> 
>> >> diff --git a/gdbserver/linux-mips-low.cc b/gdbserver/linux-mips-low.cc
>> >> index 98733709fa3..fafcdefbb06 100644
>> >> --- a/gdbserver/linux-mips-low.cc
>> >> +++ b/gdbserver/linux-mips-low.cc
>> >> @@ -623,7 +623,7 @@ mips_target::low_remove_point (raw_bkpt_type type, CORE_ADDR addr,
>> >>  				  &priv->watch_mirror);
>> >>  
>> >>    /* Only update the threads of this process.  */
>> >> -  proc->for_each_thread (pid, update_watch_registers_callback);
>> >> +  proc->for_each_thread (update_watch_registers_callback);
>> >>  
>> >>    return 0;
>> >>  }
>> >
>> > Thanks for catching this.
>> >
>> > Approved-By: Simon Marchi <simon.marchi@efficios.com>
>> 
>> Thanks; pushed.
>
> Branch gdb-16-branch also contains
> 3470a0e144df6c01f8479fa649f43aa907936e7e,
> so I'm wondering if it might be worth backporting
> this change to that branch as well?

Yep, I was going to raise this with you but forgot to do that yesterday.
I can do the backport if you want, but I may have forgotten the proper
dance.  Do I still need to create a bug?

> (just in time for teh 16.1 release, which is currently
> scheduled for this weekend!)

Great!

Cheers,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/