From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 70BIDEs1iWeQRhEAWB0awg (envelope-from ) for ; Thu, 16 Jan 2025 11:35:23 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=sergiodj.net header.i=@sergiodj.net header.a=rsa-sha256 header.s=20160602 header.b=HWBjWTza; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 222C61E100; Thu, 16 Jan 2025 11:35:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B0FD61E05C for ; Thu, 16 Jan 2025 11:35:22 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A1DB384DEEB for ; Thu, 16 Jan 2025 16:35:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A1DB384DEEB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=sergiodj.net header.i=@sergiodj.net header.a=rsa-sha256 header.s=20160602 header.b=HWBjWTza Received: from mail.sergiodj.net (mail.sergiodj.net [IPv6:2a01:4f8:13a:6e8:160::1]) by sourceware.org (Postfix) with ESMTPS id C9656384F02D for ; Thu, 16 Jan 2025 16:28:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9656384F02D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=sergiodj.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sergiodj.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C9656384F02D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a01:4f8:13a:6e8:160::1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737044914; cv=none; b=BuJVs7tA1HV1J6ZmiaBCzncAtJSw0XiSJqz3YyzLAEQI1qhduBpDhkalJHlKUeCf5CdWQpPu0KGAzKQJjnahxbpI+JSreAiK362ZOohQLN2djjJ/Lkiy9fi7KOOwlG9uitV5A8GT578h3zLjhJfrTsUpnUn5HaqC+dvrKSeJW+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737044914; c=relaxed/simple; bh=r1zWhUcWHwxK3KujEKNJDO8/pwDkNDiL3mAIqa3TYCM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OS1OqUTCWMHhu8vJQgz7e0rNgJhRveyQFgGtZvNzt5YUY5isv6sIKS6pvpb/0UIIgsVaF9rOnPJFDQDtu7u/dXm/hY04XNcxoZssKIJ46G/6+5Fp7MACs7KKw+4LwRftoQTZD5T31YgudFRMvugKMKCP0BjzGD8ilj/Y+eJPtfE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9656384F02D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sergiodj.net; s=20160602; t=1737044912; bh=r1zWhUcWHwxK3KujEKNJDO8/pwDkNDiL3mAIqa3TYCM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HWBjWTzaDmHf3cGTTt2HRzpFNOyZBzzvf3sq/g/GKJWiv1HiNytmuih4LQLclMKEP E/R1fuDwGl/qsijvL0kmLndPoY9RKMcwftsxJRpF6eY+5wXWlDRj04Ez8PDUKmZTfo bD5A/qzMw84S2DnTIixVFOVdNQXeOfZydWXg6qp4= From: Sergio Durigan Junior To: Joel Brobecker Cc: Simon Marchi , GDB Patches , Simon Marchi Subject: Re: [PATCH] gdbserver: Fix build on MIPS In-Reply-To: (Joel Brobecker's message of "Thu, 16 Jan 2025 08:53:40 +0400") References: <20250116011055.4022193-1-sergiodj@sergiodj.net> <6cb5835d-3c50-4fd1-a9a7-39ac2c1d66d6@simark.ca> <87frlj766f.fsf@sergiodj.net> X-URL: http://blog.sergiodj.net Date: Thu, 16 Jan 2025 11:28:31 -0500 Message-ID: <87tt9ywwnk.fsf@sergiodj.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wednesday, January 15 2025, Joel Brobecker wrote: > Hi Sergio, Hey Joel! > On Wed, Jan 15, 2025 at 11:07:20PM -0500, Sergio Durigan Junior wrote: >> On Wednesday, January 15 2025, Simon Marchi wrote: >> >> > On 2025-01-15 20:10, Sergio Durigan Junior wrote: >> >> Commit 3470a0e144df6c01f8479fa649f43aa907936e7e inadvertently broke >> >> the build on MIPS because it's passing a non-existent "pid" argument >> >> to "proc->for_each_thread". This commit fixes the problem by removing >> >> the argument from the call. >> >> >> >> Signed-off-by: Sergio Durigan Junior >> >> --- >> >> gdbserver/linux-mips-low.cc | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/gdbserver/linux-mips-low.cc b/gdbserver/linux-mips-low.cc >> >> index 98733709fa3..fafcdefbb06 100644 >> >> --- a/gdbserver/linux-mips-low.cc >> >> +++ b/gdbserver/linux-mips-low.cc >> >> @@ -623,7 +623,7 @@ mips_target::low_remove_point (raw_bkpt_type type, CORE_ADDR addr, >> >> &priv->watch_mirror); >> >> >> >> /* Only update the threads of this process. */ >> >> - proc->for_each_thread (pid, update_watch_registers_callback); >> >> + proc->for_each_thread (update_watch_registers_callback); >> >> >> >> return 0; >> >> } >> > >> > Thanks for catching this. >> > >> > Approved-By: Simon Marchi >> >> Thanks; pushed. > > Branch gdb-16-branch also contains > 3470a0e144df6c01f8479fa649f43aa907936e7e, > so I'm wondering if it might be worth backporting > this change to that branch as well? Yep, I was going to raise this with you but forgot to do that yesterday. I can do the backport if you want, but I may have forgotten the proper dance. Do I still need to create a bug? > (just in time for teh 16.1 release, which is currently > scheduled for this weekend!) Great! Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/