Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@sergiodj.net>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>,
	Sergio Durigan Junior <sergiodj@sergiodj.net>
Subject: [PATCH] gdbserver: Fix build on MIPS
Date: Wed, 15 Jan 2025 20:10:55 -0500	[thread overview]
Message-ID: <20250116011055.4022193-1-sergiodj@sergiodj.net> (raw)

Commit 3470a0e144df6c01f8479fa649f43aa907936e7e inadvertently broke
the build on MIPS because it's passing a non-existent "pid" argument
to "proc->for_each_thread".  This commit fixes the problem by removing
the argument from the call.

Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
---
 gdbserver/linux-mips-low.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbserver/linux-mips-low.cc b/gdbserver/linux-mips-low.cc
index 98733709fa3..fafcdefbb06 100644
--- a/gdbserver/linux-mips-low.cc
+++ b/gdbserver/linux-mips-low.cc
@@ -623,7 +623,7 @@ mips_target::low_remove_point (raw_bkpt_type type, CORE_ADDR addr,
 				  &priv->watch_mirror);
 
   /* Only update the threads of this process.  */
-  proc->for_each_thread (pid, update_watch_registers_callback);
+  proc->for_each_thread (update_watch_registers_callback);
 
   return 0;
 }
-- 
2.45.2


             reply	other threads:[~2025-01-16  1:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16  1:10 Sergio Durigan Junior [this message]
2025-01-16  2:26 ` Simon Marchi
2025-01-16  4:07   ` Sergio Durigan Junior
2025-01-16  4:53     ` Joel Brobecker
2025-01-16 16:28       ` Sergio Durigan Junior
2025-01-17  2:35         ` Joel Brobecker
2025-01-17  2:50           ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250116011055.4022193-1-sergiodj@sergiodj.net \
    --to=sergiodj@sergiodj.net \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox