Re: [PATCH] gdbserver: Fix build on MIPS

[Simon Marchi <simark@simark.ca>]

On 2025-01-15 20:10, Sergio Durigan Junior wrote:
> Commit 3470a0e144df6c01f8479fa649f43aa907936e7e inadvertently broke
> the build on MIPS because it's passing a non-existent "pid" argument
> to "proc->for_each_thread".  This commit fixes the problem by removing
> the argument from the call.
> 
> Signed-off-by: Sergio Durigan Junior <sergiodj@sergiodj.net>
> ---
>  gdbserver/linux-mips-low.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdbserver/linux-mips-low.cc b/gdbserver/linux-mips-low.cc
> index 98733709fa3..fafcdefbb06 100644
> --- a/gdbserver/linux-mips-low.cc
> +++ b/gdbserver/linux-mips-low.cc
> @@ -623,7 +623,7 @@ mips_target::low_remove_point (raw_bkpt_type type, CORE_ADDR addr,
>  				  &priv->watch_mirror);
>  
>    /* Only update the threads of this process.  */
> -  proc->for_each_thread (pid, update_watch_registers_callback);
> +  proc->for_each_thread (update_watch_registers_callback);
>  
>    return 0;
>  }

Thanks for catching this.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon