From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /AqXGnFuiGf/jhAAWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 21:26:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736994417; bh=zfwVyKOYpXQwzy/GK/HwBTtM6tzWJHEcJFhVQLZtGLY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ACXVEamLA/O/dtvXfdTMGPz8Ow+fpfrsMs8OxCM1HZazbkvGW6LcoYK/2iqbhDu2L g0YCTCGTbnay7e/paRh+uX7iav2FpXfCjzmEEzkp+5z9/WcaJ4TRkR8en21ltp2e49 3Ipi1Slsdom22xgRQRxqbfSjGwUGH7mPVLp20QyU= Received: by simark.ca (Postfix, from userid 112) id 5DFA51E100; Wed, 15 Jan 2025 21:26:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=E+lXo25t; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=LnBg7wgg; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 46D481E05C for ; Wed, 15 Jan 2025 21:26:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B91FC3851154 for ; Thu, 16 Jan 2025 02:26:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B91FC3851154 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=E+lXo25t; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=LnBg7wgg Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BCFFE385E00C for ; Thu, 16 Jan 2025 02:26:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BCFFE385E00C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BCFFE385E00C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736994382; cv=none; b=fkKFxl0maqfeNRM6E8kwFs7LrcacgsFcUIakCKdY5XoTdlitXYe8Bpp4umubBkJNGqlNqlhDd9J3FhVMomBaZnHeBZcTWEbOBPiW63PuvzRWirR3ZiLKAwSvr9FZVuAjfjf/8m0B1HSQCE8/5qi0+fFyeyMOJmrGJKT0u9OpI8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736994382; c=relaxed/simple; bh=zfwVyKOYpXQwzy/GK/HwBTtM6tzWJHEcJFhVQLZtGLY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=h7/cZkbTtYOLLaMGqq8nrxYzILtmIY5bQTq0pDdGiHJOo+R7yKSXgV1AJPTk6sGD7mP6IWSRuwnOxGvC+k9lDYoz24Dj5qF7LzmarFaQCvVvWevwrtcTHFlKYJT+V8E3w8x/SzUo/mfV1n3T9wJtihlfxGg7aEjQaGDTltb/d2U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BCFFE385E00C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736994381; bh=zfwVyKOYpXQwzy/GK/HwBTtM6tzWJHEcJFhVQLZtGLY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E+lXo25tt1lQbaSlbpItlUbfJwy+LN75z17idwq78Tt113Wshvlk6IjGwELcq4D5F iaNsj6X7YGiwbms9YoaNTPNu6plGlYEUC564Ud2D/lMmqPXzXdp4erL8fBpF9/tyU0 ZfvSzsqd9KQXcHgSvaubeXqHXoqmaIbLjbongAto= Received: by simark.ca (Postfix, from userid 112) id 6E9261E10A; Wed, 15 Jan 2025 21:26:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736994380; bh=zfwVyKOYpXQwzy/GK/HwBTtM6tzWJHEcJFhVQLZtGLY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LnBg7wggSSbn46NRm+AJRawuQnvnDLqAtYzEpvoWcnD0U2JL/rM2ZotOSqlHrw2Cc 6x2r7+K3OEQ/l7n0SKMb2OOA9a4jp90SIKKf4Kz/72Cho2Rp62SoVb8YWosqDF0iCy 4rt/KgxLCpCFUq8lWOQLI+rfGFoeePifSodqWvEY= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6771A1E05C; Wed, 15 Jan 2025 21:26:20 -0500 (EST) Message-ID: <6cb5835d-3c50-4fd1-a9a7-39ac2c1d66d6@simark.ca> Date: Wed, 15 Jan 2025 21:26:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbserver: Fix build on MIPS To: Sergio Durigan Junior , GDB Patches Cc: Simon Marchi References: <20250116011055.4022193-1-sergiodj@sergiodj.net> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250116011055.4022193-1-sergiodj@sergiodj.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-01-15 20:10, Sergio Durigan Junior wrote: > Commit 3470a0e144df6c01f8479fa649f43aa907936e7e inadvertently broke > the build on MIPS because it's passing a non-existent "pid" argument > to "proc->for_each_thread". This commit fixes the problem by removing > the argument from the call. > > Signed-off-by: Sergio Durigan Junior > --- > gdbserver/linux-mips-low.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbserver/linux-mips-low.cc b/gdbserver/linux-mips-low.cc > index 98733709fa3..fafcdefbb06 100644 > --- a/gdbserver/linux-mips-low.cc > +++ b/gdbserver/linux-mips-low.cc > @@ -623,7 +623,7 @@ mips_target::low_remove_point (raw_bkpt_type type, CORE_ADDR addr, > &priv->watch_mirror); > > /* Only update the threads of this process. */ > - proc->for_each_thread (pid, update_watch_registers_callback); > + proc->for_each_thread (update_watch_registers_callback); > > return 0; > } Thanks for catching this. Approved-By: Simon Marchi Simon