From: Andreas Schwab <schwab@linux-m68k.org>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/3] Implement 'set print frame-info|frame-arguments presence'.
Date: Sun, 05 May 2019 20:24:00 -0000 [thread overview]
Message-ID: <87sgtsbqfu.fsf@igel.home> (raw)
In-Reply-To: <20190504215538.29821-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 4 May 2019 23:55:36 +0200")
On Mai 04 2019, Philippe Waroquiers <philippe.waroquiers@skynet.be> wrote:
> @@ -766,13 +779,42 @@ do_gdb_disassembly (struct gdbarch *gdbarch,
> }
> }
>
> +/* The possible choices of "set print frame-info", and the value
> + of this setting. */
> +
> +static const char *const print_frame_info_choices[] =
> + {"src_line", "location", "src_and_loc", "loc_and_address", "short_loc",
> + "auto", NULL};
I think it would be nicer to use dashes instead of underscores, and not
abbreviate the words.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2019-05-05 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 21:57 [RFA 0/3] Better control about frame information to print Philippe Waroquiers
2019-05-04 21:57 ` [RFA 3/3] Document 'set print frame-info|frame-arguments presence' Philippe Waroquiers
2019-05-05 16:43 ` Eli Zaretskii
2019-05-04 21:57 ` [RFA 2/3] Test " Philippe Waroquiers
2019-05-04 21:57 ` [RFA 1/3] Implement " Philippe Waroquiers
2019-05-05 20:24 ` Andreas Schwab [this message]
2019-05-06 19:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgtsbqfu.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox