From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90660 invoked by alias); 5 May 2019 20:24:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90620 invoked by uid 89); 5 May 2019 20:24:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=nicer, underscores, H*M:home, H*MI:home X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 05 May 2019 20:24:12 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 44xy544QHCz1rWxb; Sun, 5 May 2019 22:24:08 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 44xy544CHKz1rN3N; Sun, 5 May 2019 22:24:08 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id m9mPfwLEc5_p; Sun, 5 May 2019 22:24:07 +0200 (CEST) Received: from igel.home (ppp-46-244-180-226.dynamic.mnet-online.de [46.244.180.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 5 May 2019 22:24:07 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id EBFDE2C11EE; Sun, 5 May 2019 22:24:05 +0200 (CEST) From: Andreas Schwab To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Implement 'set print frame-info|frame-arguments presence'. References: <20190504215538.29821-1-philippe.waroquiers@skynet.be> <20190504215538.29821-2-philippe.waroquiers@skynet.be> X-Yow: Disco oil bussing will create a throbbing naugahide pipeline running straight to the tropics from the rug producing regions and devalue the dollar! Date: Sun, 05 May 2019 20:24:00 -0000 In-Reply-To: <20190504215538.29821-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 4 May 2019 23:55:36 +0200") Message-ID: <87sgtsbqfu.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00160.txt.bz2 On Mai 04 2019, Philippe Waroquiers wrote: > @@ -766,13 +779,42 @@ do_gdb_disassembly (struct gdbarch *gdbarch, > } > } > > +/* The possible choices of "set print frame-info", and the value > + of this setting. */ > + > +static const char *const print_frame_info_choices[] = > + {"src_line", "location", "src_and_loc", "loc_and_address", "short_loc", > + "auto", NULL}; I think it would be nicer to use dashes instead of underscores, and not abbreviate the words. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."