Re: [RFA 3/3] Document 'set print frame-info|frame-arguments presence'.

[Eli Zaretskii <eliz@gnu.org>]

> From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> Date: Sat,  4 May 2019 23:55:38 +0200
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index b21b2cbb47..893b220acc 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -48,6 +48,18 @@ show may-call-functions
>    an error when a command (such as print expression) calls a function
>    in the program.
>  
> +set print frame-info [short_loc|location|loc_and_address|src_and_loc
> +                        |src_line|auto]
> +show print frame-info
> +  This controls what frame information is printed by the commands printing
> +  a frame.

How about a couple of examples of commands that will be sensitive to
this setting?

> +The command @kbd{set print frame-info} (see @ref{Print Settings}) controls
> +what frame information is printed.      ^^^^^^^^

Please use @pxref instead of "see @ref" there.

>  @cindex do not print frame argument values
> +@cindex do not print frame argument names

These two entries are too similar to be useful.  I suggest to leave
just one, saying "do not print frame arguments".

> +@item presence
> +Only the presence of arguments is signaled by @code{@dots{}}.
                                     ^^^^^^^^
"indicated"

> +the debugger prints a frame.  See @ref{Frames} and @ref{Backtrace}
                                                 ^                   ^
A comma (or a period) should follow the closing braces.

> +for a general explanation about frames and frame information.
> +Note that some other settings (such as @code{set print frame-arguments}
> +Print the frame level, the program counter if not at the
                                             ^
A comma is missing there.

> +beginning of the location source line, the function, the function
> +arguments.
> +@item location
> +Same as @code{short_loc} but also print the source file and source line
> +number.
> +@item loc_and_address
> +Same as @code{location} but print the program counter even if located at the
> +beginning of the location source line.
> +@item src_line
> +Print the program counter if not at the beginning of the location
> +source line, the line number and the source line.
> +@item src_and_loc
> +Print what @code{location} and @code{src_line} are printing.
> +@item auto
> +The information printed for a frame is decided automatically
> +by the @value{GDBN} command that prints a frame.
> +For example, @code{frame} prints the information printed by
> +@code{src_and_loc} while @code{stepi} will switch between
> +@code{src_line} and @code{src_and_loc} depending on the program counter.

Please state what is the default.

Thanks.