Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/3] Implement 'set print frame-info|frame-arguments presence'.
Date: Mon, 06 May 2019 19:43:00 -0000	[thread overview]
Message-ID: <877eb3nzbr.fsf@tromey.com> (raw)
In-Reply-To: <20190504215538.29821-2-philippe.waroquiers@skynet.be> (Philippe	Waroquiers's message of "Sat, 4 May 2019 23:55:36 +0200")

>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:

Philippe> New settings allow to better control what frame information is printed.
Philippe> 'set print frame-info' allows to override the default frame information
Philippe> printed when a GDB command prints a frame.

Philippe> It is now possible to have very short frame information by using the
Philippe> new 'set print frame-arguments presence' and 'set print frame-info short_loc'.

I didn't read the patch in detail yet, but I noticed this:

Philippe> +	* stack.c (print_frame_arguments_choices): New value 'presence'.
Philippe> +	(print_frame_args): Only print dots for args if print frame-arguments
Philippe> +	is 'presence'.
Philippe> +	(print_what_frame_info_string, print_what_frame_info)
Philippe> +	(set_print_frame_info_command): New variables and function.
Philippe> +	(print_frame_info): Update comment.  Use print_what_frame_info
Philippe> +	to decide what to print.

There's a whole separate set of frame-printing functions in
python/py-framefilter.c.  Those must be updated as well.

thanks,
Tom


      parent reply	other threads:[~2019-05-06 19:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-04 21:57 [RFA 0/3] Better control about frame information to print Philippe Waroquiers
2019-05-04 21:57 ` [RFA 2/3] Test 'set print frame-info|frame-arguments presence' Philippe Waroquiers
2019-05-04 21:57 ` [RFA 3/3] Document " Philippe Waroquiers
2019-05-05 16:43   ` Eli Zaretskii
2019-05-04 21:57 ` [RFA 1/3] Implement " Philippe Waroquiers
2019-05-05 20:24   ` Andreas Schwab
2019-05-06 19:43   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eb3nzbr.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox