From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98374 invoked by alias); 6 May 2019 19:43:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98365 invoked by uid 89); 6 May 2019 19:43:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1167 X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.180.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 May 2019 19:43:39 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id D9D9679D5 for ; Mon, 6 May 2019 14:43:37 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id NjWTheBAz2PzONjWTh6cYy; Mon, 06 May 2019 14:43:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kW4Zh/sd7k/S5JKCLpcoM7VX4tqNU7ZZl6YcXxY20BY=; b=XqoCqiNM0pSAcLaRnal6+HpCgi EeAC3OWDwz0wfKa26er47QtON+nIi/ePkDP8raN7U6oGB1T7PmKIxsf7Ko5GnYvWtzTJRenXVbVVr j9oa73N5s2pl6GvGlAy3/EvKf; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:44438 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hNjWT-0039Pv-MB; Mon, 06 May 2019 14:43:37 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Implement 'set print frame-info|frame-arguments presence'. References: <20190504215538.29821-1-philippe.waroquiers@skynet.be> <20190504215538.29821-2-philippe.waroquiers@skynet.be> Date: Mon, 06 May 2019 19:43:00 -0000 In-Reply-To: <20190504215538.29821-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 4 May 2019 23:55:36 +0200") Message-ID: <877eb3nzbr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00176.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> New settings allow to better control what frame information is printed. Philippe> 'set print frame-info' allows to override the default frame information Philippe> printed when a GDB command prints a frame. Philippe> It is now possible to have very short frame information by using the Philippe> new 'set print frame-arguments presence' and 'set print frame-info short_loc'. I didn't read the patch in detail yet, but I noticed this: Philippe> + * stack.c (print_frame_arguments_choices): New value 'presence'. Philippe> + (print_frame_args): Only print dots for args if print frame-arguments Philippe> + is 'presence'. Philippe> + (print_what_frame_info_string, print_what_frame_info) Philippe> + (set_print_frame_info_command): New variables and function. Philippe> + (print_frame_info): Update comment. Use print_what_frame_info Philippe> + to decide what to print. There's a whole separate set of frame-printing functions in python/py-framefilter.c. Those must be updated as well. thanks, Tom