From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68853 invoked by alias); 5 May 2019 16:43:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68828 invoked by uid 89); 5 May 2019 16:43:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=sensitive X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 05 May 2019 16:43:06 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hNKEA-0007M4-HV; Sun, 05 May 2019 12:43:02 -0400 Received: from [176.228.60.248] (port=4828 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hNKEA-00015m-2U; Sun, 05 May 2019 12:43:02 -0400 Date: Sun, 05 May 2019 16:43:00 -0000 Message-Id: <83y33kkg3h.fsf@gnu.org> From: Eli Zaretskii To: Philippe Waroquiers CC: gdb-patches@sourceware.org In-reply-to: <20190504215538.29821-4-philippe.waroquiers@skynet.be> (message from Philippe Waroquiers on Sat, 4 May 2019 23:55:38 +0200) Subject: Re: [RFA 3/3] Document 'set print frame-info|frame-arguments presence'. References: <20190504215538.29821-1-philippe.waroquiers@skynet.be> <20190504215538.29821-4-philippe.waroquiers@skynet.be> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00158.txt.bz2 > From: Philippe Waroquiers > Cc: Philippe Waroquiers > Date: Sat, 4 May 2019 23:55:38 +0200 > > diff --git a/gdb/NEWS b/gdb/NEWS > index b21b2cbb47..893b220acc 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -48,6 +48,18 @@ show may-call-functions > an error when a command (such as print expression) calls a function > in the program. > > +set print frame-info [short_loc|location|loc_and_address|src_and_loc > + |src_line|auto] > +show print frame-info > + This controls what frame information is printed by the commands printing > + a frame. How about a couple of examples of commands that will be sensitive to this setting? > +The command @kbd{set print frame-info} (see @ref{Print Settings}) controls > +what frame information is printed. ^^^^^^^^ Please use @pxref instead of "see @ref" there. > @cindex do not print frame argument values > +@cindex do not print frame argument names These two entries are too similar to be useful. I suggest to leave just one, saying "do not print frame arguments". > +@item presence > +Only the presence of arguments is signaled by @code{@dots{}}. ^^^^^^^^ "indicated" > +the debugger prints a frame. See @ref{Frames} and @ref{Backtrace} ^ ^ A comma (or a period) should follow the closing braces. > +for a general explanation about frames and frame information. > +Note that some other settings (such as @code{set print frame-arguments} > +Print the frame level, the program counter if not at the ^ A comma is missing there. > +beginning of the location source line, the function, the function > +arguments. > +@item location > +Same as @code{short_loc} but also print the source file and source line > +number. > +@item loc_and_address > +Same as @code{location} but print the program counter even if located at the > +beginning of the location source line. > +@item src_line > +Print the program counter if not at the beginning of the location > +source line, the line number and the source line. > +@item src_and_loc > +Print what @code{location} and @code{src_line} are printing. > +@item auto > +The information printed for a frame is decided automatically > +by the @value{GDBN} command that prints a frame. > +For example, @code{frame} prints the information printed by > +@code{src_and_loc} while @code{stepi} will switch between > +@code{src_line} and @code{src_and_loc} depending on the program counter. Please state what is the default. Thanks.