Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Move file_and_directory to new file and C++-ize
Date: Tue, 30 Nov 2021 10:44:31 -0700	[thread overview]
Message-ID: <87sfvdv8qo.fsf@tromey.com> (raw)
In-Reply-To: <20211130161818.m7hlyoebsqasfo6y@Plymouth> (Lancelot SIX's message of "Tue, 30 Nov 2021 16:18:18 +0000")

>> +struct file_and_directory
>> +{
>> +  file_and_directory (const char *name_, const char *dir_)
>> +    : name (name_),
>> +      comp_dir (dir_)

Lancelot> The members are usually prefixed with 'm_'.  I think you change that in
Lancelot> then next patch, but I feel this change would be relevant in the
Lancelot> 'c++ization' done by the current one.

Yeah, I did that in the wrong patch.
I've fixed it locally now.

>> +  /* The filename.  This is never NULL.  */

Lancelot> From how the class is implemented, it looks like this comment is not
Lancelot> accurate anymore and NAME can be NULL.

Thanks, I made this change as well.

Tom

  reply	other threads:[~2021-11-30 17:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  1:33 [PATCH 0/3] Refactor find_file_and_directory Tom Tromey
2021-11-30  1:33 ` [PATCH 1/3] Remove Irix case from find_file_and_directory Tom Tromey
2021-12-04 10:43   ` Joel Brobecker via Gdb-patches
2021-11-30  1:33 ` [PATCH 2/3] Move file_and_directory to new file and C++-ize Tom Tromey
2021-11-30 16:18   ` Lancelot SIX via Gdb-patches
2021-11-30 17:44     ` Tom Tromey [this message]
2021-12-04 10:38   ` Joel Brobecker via Gdb-patches
2021-12-04 18:22     ` Tom Tromey
2021-11-30  1:33 ` [PATCH 3/3] Cache the result of find_file_and_directory Tom Tromey
2021-12-04 10:42   ` Joel Brobecker via Gdb-patches
2021-12-04 18:22     ` Tom Tromey
2021-12-05  2:31       ` Simon Marchi via Gdb-patches
2021-12-05  3:46         ` Tom Tromey
2021-12-05  3:47           ` Simon Marchi via Gdb-patches
2021-12-05 20:17             ` Tom Tromey
2021-12-06  1:54               ` Simon Marchi via Gdb-patches
2021-12-07  4:30                 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfvdv8qo.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox