From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>, Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Cache the result of find_file_and_directory
Date: Sat, 4 Dec 2021 21:31:19 -0500 [thread overview]
Message-ID: <104bfab9-d713-1ec8-3a44-09a8403e2c3f@polymtl.ca> (raw)
In-Reply-To: <87tufotela.fsf@tromey.com>
On 2021-12-04 13:22, Tom Tromey wrote:
>>> This changes the DWARF reader to cache the result of
>>> find_file_and_directory. This is not especially important now, but it
>>> will help the new DWARF indexer.
>
> Joel> With the renaming of the class members moved to patch #2 (I made the
> Joel> assumption that all the changes in file-and-dir.h are about that, at
> Joel> least from what I could see), this patch looks good to me.
>
> Thanks, I'm going to check these in now.
>
> Tom
>
Hi Tom,
I see these failures on Ubuntu 20.04, when building with
AddressSanitizer, starting with this patch.
gdb.dwarf2/imported-unit.exp - ptype main
gdb.dwarf2/imported-unit-abstract-const-value.exp - p aaa
gdb.dwarf2/imported-unit-bp-c.exp - break /tmp/imported-unit-bp-alt.c:19
gdb.dwarf2/inlined_subroutine-inheritance.exp - setting breakpoint at bytes_repeat (eof)
Simon
next prev parent reply other threads:[~2021-12-05 2:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 1:33 [PATCH 0/3] Refactor find_file_and_directory Tom Tromey
2021-11-30 1:33 ` [PATCH 1/3] Remove Irix case from find_file_and_directory Tom Tromey
2021-12-04 10:43 ` Joel Brobecker via Gdb-patches
2021-11-30 1:33 ` [PATCH 2/3] Move file_and_directory to new file and C++-ize Tom Tromey
2021-11-30 16:18 ` Lancelot SIX via Gdb-patches
2021-11-30 17:44 ` Tom Tromey
2021-12-04 10:38 ` Joel Brobecker via Gdb-patches
2021-12-04 18:22 ` Tom Tromey
2021-11-30 1:33 ` [PATCH 3/3] Cache the result of find_file_and_directory Tom Tromey
2021-12-04 10:42 ` Joel Brobecker via Gdb-patches
2021-12-04 18:22 ` Tom Tromey
2021-12-05 2:31 ` Simon Marchi via Gdb-patches [this message]
2021-12-05 3:46 ` Tom Tromey
2021-12-05 3:47 ` Simon Marchi via Gdb-patches
2021-12-05 20:17 ` Tom Tromey
2021-12-06 1:54 ` Simon Marchi via Gdb-patches
2021-12-07 4:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=104bfab9-d713-1ec8-3a44-09a8403e2c3f@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=brobecker@adacore.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox