Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Remove Irix case from find_file_and_directory
Date: Sat, 4 Dec 2021 14:43:07 +0400	[thread overview]
Message-ID: <YatGO8FbrZQuvasB@adacore.com> (raw)
In-Reply-To: <20211130013304.4135367-2-tom@tromey.com>

> find_file_and_directory has a special case for the Irix 6.2 compiler.
> Since this is long obsolete, this patch removes it.

Looks good to me. Thanks Tom!

> ---
>  gdb/dwarf2/read.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
> index 57538fc0adf..3cf0c9ea2a8 100644
> --- a/gdb/dwarf2/read.c
> +++ b/gdb/dwarf2/read.c
> @@ -10509,15 +10509,6 @@ find_file_and_directory (struct die_info *die, struct dwarf2_cu *cu)
>  	res.comp_dir
>  	  = cu->per_objfile->objfile->intern (comp_dir_storage.c_str ());
>      }
> -  if (res.comp_dir != NULL)
> -    {
> -      /* Irix 6.2 native cc prepends <machine>.: to the compilation
> -	 directory, get rid of it.  */
> -      const char *cp = strchr (res.comp_dir, ':');
> -
> -      if (cp && cp != res.comp_dir && cp[-1] == '.' && cp[1] == '/')
> -	res.comp_dir = cp + 1;
> -    }
>  
>    if (res.name == NULL)
>      res.name = "<unknown>";
> -- 
> 2.31.1
> 

-- 
Joel

  reply	other threads:[~2021-12-04 10:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  1:33 [PATCH 0/3] Refactor find_file_and_directory Tom Tromey
2021-11-30  1:33 ` [PATCH 1/3] Remove Irix case from find_file_and_directory Tom Tromey
2021-12-04 10:43   ` Joel Brobecker via Gdb-patches [this message]
2021-11-30  1:33 ` [PATCH 2/3] Move file_and_directory to new file and C++-ize Tom Tromey
2021-11-30 16:18   ` Lancelot SIX via Gdb-patches
2021-11-30 17:44     ` Tom Tromey
2021-12-04 10:38   ` Joel Brobecker via Gdb-patches
2021-12-04 18:22     ` Tom Tromey
2021-11-30  1:33 ` [PATCH 3/3] Cache the result of find_file_and_directory Tom Tromey
2021-12-04 10:42   ` Joel Brobecker via Gdb-patches
2021-12-04 18:22     ` Tom Tromey
2021-12-05  2:31       ` Simon Marchi via Gdb-patches
2021-12-05  3:46         ` Tom Tromey
2021-12-05  3:47           ` Simon Marchi via Gdb-patches
2021-12-05 20:17             ` Tom Tromey
2021-12-06  1:54               ` Simon Marchi via Gdb-patches
2021-12-07  4:30                 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YatGO8FbrZQuvasB@adacore.com \
    --to=gdb-patches@sourceware.org \
    --cc=brobecker@adacore.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox