From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EkyVNEBjpmGPbwAAWB0awg (envelope-from ) for ; Tue, 30 Nov 2021 12:45:36 -0500 Received: by simark.ca (Postfix, from userid 112) id C19911F0CE; Tue, 30 Nov 2021 12:45:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB1561EDF0 for ; Tue, 30 Nov 2021 12:45:35 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 297FA385E83D for ; Tue, 30 Nov 2021 17:45:35 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.104]) by sourceware.org (Postfix) with ESMTPS id E834A385E01D for ; Tue, 30 Nov 2021 17:44:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E834A385E01D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id CA83013849 for ; Tue, 30 Nov 2021 11:44:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id s7BAmMWOOJZhNs7BAmXWxs; Tue, 30 Nov 2021 11:44:33 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qU/KW4W4netw3ZYPk7i77OhgC68a40IjIRXex13D1z4=; b=XmM2CQqGPOhGuR74C77j4nKHnb iIeLaLzZUsNDYBipNmSfoaiokOBOrmOm2F9xYQIlQ0ADx714jCA3CKKw0N7qxbCi1K/YNPMUpzMQ6 +yrkTw4rN+fbALfZBScxVfACg; Received: from 97-122-84-67.hlrn.qwest.net ([97.122.84.67]:40426 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ms7BA-001Bcb-8X; Tue, 30 Nov 2021 10:44:32 -0700 From: Tom Tromey To: Lancelot SIX Subject: Re: [PATCH 2/3] Move file_and_directory to new file and C++-ize References: <20211130013304.4135367-1-tom@tromey.com> <20211130013304.4135367-3-tom@tromey.com> <20211130161818.m7hlyoebsqasfo6y@Plymouth> X-Attribution: Tom Date: Tue, 30 Nov 2021 10:44:31 -0700 In-Reply-To: <20211130161818.m7hlyoebsqasfo6y@Plymouth> (Lancelot SIX's message of "Tue, 30 Nov 2021 16:18:18 +0000") Message-ID: <87sfvdv8qo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.84.67 X-Source-L: No X-Exim-ID: 1ms7BA-001Bcb-8X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-84-67.hlrn.qwest.net (localhost.localdomain) [97.122.84.67]:40426 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> +struct file_and_directory >> +{ >> + file_and_directory (const char *name_, const char *dir_) >> + : name (name_), >> + comp_dir (dir_) Lancelot> The members are usually prefixed with 'm_'. I think you change that in Lancelot> then next patch, but I feel this change would be relevant in the Lancelot> 'c++ization' done by the current one. Yeah, I did that in the wrong patch. I've fixed it locally now. >> + /* The filename. This is never NULL. */ Lancelot> From how the class is implemented, it looks like this comment is not Lancelot> accurate anymore and NAME can be NULL. Thanks, I made this change as well. Tom