From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit 2/2] Import gnulib's errno module.
Date: Tue, 18 Dec 2012 18:38:00 -0000 [thread overview]
Message-ID: <87r4mnqk90.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20121218181104.GM3273@adacore.com> (Joel Brobecker's message of "Tue, 18 Dec 2012 22:11:04 +0400")
Joel> Yes, indeed. I don't know how to solve the problem, however,
Joel> short of maybe asking gnulib to define it as ENOENT as well.
Joel> But I don't know how I could justify this request, since
Joel> other projects might have chosen a different value.
A couple choices --
1. Ensure that charset.c includes the files in the correct order.
2. Back out your change and promote the EILSEQ define out of charset.c
to somewhere more global in gdb.
Joel> IMO, a more promising approach would be to convince libiconv
Joel> to use gnulib's errno instead.
You could try it but that option scares me a little in that what if
there is gnulib version skew between gdb and libiconv?
Tom
next prev parent reply other threads:[~2012-12-18 18:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 15:08 [RFA/commit 1/2] update gnulib to 2012-11-05 Joel Brobecker
2012-12-17 15:08 ` [RFA/commit 2/2] Import gnulib's errno module Joel Brobecker
2012-12-18 6:07 ` Joel Brobecker
2012-12-18 16:40 ` Tom Tromey
2012-12-18 16:46 ` Tom Tromey
2012-12-18 16:55 ` Joel Brobecker
2012-12-18 16:51 ` Joel Brobecker
2012-12-18 17:03 ` Tom Tromey
2012-12-18 18:11 ` Joel Brobecker
2012-12-18 18:38 ` Tom Tromey [this message]
2012-12-18 19:16 ` Eli Zaretskii
2012-12-18 21:30 ` Tom Tromey
2012-12-18 21:38 ` Eli Zaretskii
2012-12-19 3:55 ` Joel Brobecker
2012-12-19 4:25 ` Joel Brobecker
2012-12-19 15:44 ` Tom Tromey
2013-01-02 10:44 ` Joel Brobecker
2012-12-19 4:16 ` Reverted: " Joel Brobecker
2012-12-17 18:26 ` [RFA/commit 1/2] update gnulib to 2012-11-05 Tom Tromey
2012-12-18 6:06 ` Joel Brobecker
2012-12-18 16:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4mnqk90.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox