From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19161 invoked by alias); 18 Dec 2012 18:38:05 -0000 Received: (qmail 18951 invoked by uid 22791); 18 Dec 2012 18:38:03 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 18:37:50 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIIbntQ002407 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Dec 2012 13:37:49 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBIIblJl031436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Dec 2012 13:37:48 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit 2/2] Import gnulib's errno module. References: <1355756839-11337-1-git-send-email-brobecker@adacore.com> <1355756839-11337-2-git-send-email-brobecker@adacore.com> <20121218060719.GD3273@adacore.com> <87r4mns49t.fsf@fleche.redhat.com> <20121218165035.GI3273@adacore.com> <87ehins375.fsf@fleche.redhat.com> <20121218181104.GM3273@adacore.com> Date: Tue, 18 Dec 2012 18:38:00 -0000 In-Reply-To: <20121218181104.GM3273@adacore.com> (Joel Brobecker's message of "Tue, 18 Dec 2012 22:11:04 +0400") Message-ID: <87r4mnqk90.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00657.txt.bz2 Joel> Yes, indeed. I don't know how to solve the problem, however, Joel> short of maybe asking gnulib to define it as ENOENT as well. Joel> But I don't know how I could justify this request, since Joel> other projects might have chosen a different value. A couple choices -- 1. Ensure that charset.c includes the files in the correct order. 2. Back out your change and promote the EILSEQ define out of charset.c to somewhere more global in gdb. Joel> IMO, a more promising approach would be to convince libiconv Joel> to use gnulib's errno instead. You could try it but that option scares me a little in that what if there is gnulib version skew between gdb and libiconv? Tom