From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [RFA/commit 2/2] Import gnulib's errno module.
Date: Tue, 18 Dec 2012 21:38:00 -0000 [thread overview]
Message-ID: <83a9tboxdm.fsf@gnu.org> (raw)
In-Reply-To: <87vcbzoxp8.fsf@fleche.redhat.com>
> From: Tom Tromey <tromey@redhat.com>
> Cc: brobecker@adacore.com, gdb-patches@sourceware.org
> Date: Tue, 18 Dec 2012 14:30:11 -0700
>
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>
> Eli> How about
> Eli> 3. Test for either ENOENT or EILSEQ where we now test for EILSEQ.
> Eli> ?
>
> It is tempting but I think it exposes us to libiconv's internals too
> much. That is, if libiconv changes its choice here, and we are using
> the gnulib EILSEQ, then gdb would start doing the wrong thing.
How about limiting that to known versions of libiconv, then?
I mean, I agree that this all is kludgey, but the whole issue is a
mess. A library should not define a global symbol, it should only
define symbols for its own private use.
next prev parent reply other threads:[~2012-12-18 21:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 15:08 [RFA/commit 1/2] update gnulib to 2012-11-05 Joel Brobecker
2012-12-17 15:08 ` [RFA/commit 2/2] Import gnulib's errno module Joel Brobecker
2012-12-18 6:07 ` Joel Brobecker
2012-12-18 16:40 ` Tom Tromey
2012-12-18 16:46 ` Tom Tromey
2012-12-18 16:55 ` Joel Brobecker
2012-12-18 16:51 ` Joel Brobecker
2012-12-18 17:03 ` Tom Tromey
2012-12-18 18:11 ` Joel Brobecker
2012-12-18 18:38 ` Tom Tromey
2012-12-18 19:16 ` Eli Zaretskii
2012-12-18 21:30 ` Tom Tromey
2012-12-18 21:38 ` Eli Zaretskii [this message]
2012-12-19 3:55 ` Joel Brobecker
2012-12-19 4:25 ` Joel Brobecker
2012-12-19 15:44 ` Tom Tromey
2013-01-02 10:44 ` Joel Brobecker
2012-12-19 4:16 ` Reverted: " Joel Brobecker
2012-12-17 18:26 ` [RFA/commit 1/2] update gnulib to 2012-11-05 Tom Tromey
2012-12-18 6:06 ` Joel Brobecker
2012-12-18 16:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a9tboxdm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox