Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit 2/2] Import gnulib's errno module.
Date: Tue, 18 Dec 2012 17:03:00 -0000	[thread overview]
Message-ID: <87ehins375.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20121218165035.GI3273@adacore.com> (Joel Brobecker's message of	"Tue, 18 Dec 2012 20:50:35 +0400")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I though libiconv had its own mechanism for defining EILSEQ.
Joel> Do you think the two are going to interfere?

It seems possible to me.

Suppose you have a system without EILSEQ and where libiconv is used.

libiconv will be compiled with its definition of EILSEQ.  This will
often be ENOENT, though I didn't read m4/eilseq.m4 in detail.

gnulib defines it as:

# ifndef EILSEQ
#  define EILSEQ 2015
#  define GNULIB_defined_EILSEQ 1
# endif


Now, if libiconv ever returns EILSEQ (I didn't check this), gdb will
either interpret the libiconv result properly, or not, depending on
whether the gnulib errno.h or libiconv.h is included first.

Tom


  reply	other threads:[~2012-12-18 17:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 15:08 [RFA/commit 1/2] update gnulib to 2012-11-05 Joel Brobecker
2012-12-17 15:08 ` [RFA/commit 2/2] Import gnulib's errno module Joel Brobecker
2012-12-18  6:07   ` Joel Brobecker
2012-12-18 16:40     ` Tom Tromey
2012-12-18 16:46       ` Tom Tromey
2012-12-18 16:55         ` Joel Brobecker
2012-12-18 16:51       ` Joel Brobecker
2012-12-18 17:03         ` Tom Tromey [this message]
2012-12-18 18:11           ` Joel Brobecker
2012-12-18 18:38             ` Tom Tromey
2012-12-18 19:16               ` Eli Zaretskii
2012-12-18 21:30                 ` Tom Tromey
2012-12-18 21:38                   ` Eli Zaretskii
2012-12-19  3:55               ` Joel Brobecker
2012-12-19  4:25                 ` Joel Brobecker
2012-12-19 15:44                 ` Tom Tromey
2013-01-02 10:44                   ` Joel Brobecker
2012-12-19  4:16     ` Reverted: " Joel Brobecker
2012-12-17 18:26 ` [RFA/commit 1/2] update gnulib to 2012-11-05 Tom Tromey
2012-12-18  6:06   ` Joel Brobecker
2012-12-18 16:13     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehins375.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox