From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4382 invoked by alias); 18 Dec 2012 17:03:49 -0000 Received: (qmail 4322 invoked by uid 22791); 18 Dec 2012 17:03:46 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_FN,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 17:03:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIH3B9h016671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Dec 2012 12:03:11 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBIH3An1016181 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 18 Dec 2012 12:03:10 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit 2/2] Import gnulib's errno module. References: <1355756839-11337-1-git-send-email-brobecker@adacore.com> <1355756839-11337-2-git-send-email-brobecker@adacore.com> <20121218060719.GD3273@adacore.com> <87r4mns49t.fsf@fleche.redhat.com> <20121218165035.GI3273@adacore.com> Date: Tue, 18 Dec 2012 17:03:00 -0000 In-Reply-To: <20121218165035.GI3273@adacore.com> (Joel Brobecker's message of "Tue, 18 Dec 2012 20:50:35 +0400") Message-ID: <87ehins375.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00648.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I though libiconv had its own mechanism for defining EILSEQ. Joel> Do you think the two are going to interfere? It seems possible to me. Suppose you have a system without EILSEQ and where libiconv is used. libiconv will be compiled with its definition of EILSEQ. This will often be ENOENT, though I didn't read m4/eilseq.m4 in detail. gnulib defines it as: # ifndef EILSEQ # define EILSEQ 2015 # define GNULIB_defined_EILSEQ 1 # endif Now, if libiconv ever returns EILSEQ (I didn't check this), gdb will either interpret the libiconv result properly, or not, depending on whether the gnulib errno.h or libiconv.h is included first. Tom