From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97192-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27780 invoked by alias); 18 Dec 2012 21:38:25 -0000
Received: (qmail 27572 invoked by uid 22791); 18 Dec 2012 21:38:23 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 21:38:14 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MF800L00X9U3B00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 18 Dec 2012 23:36:56 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MF800K4MXDJKZA0@a-mtaout22.012.net.il>; Tue, 18 Dec 2012 23:36:56 +0200 (IST)
Date: Tue, 18 Dec 2012 21:38:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA/commit 2/2] Import gnulib's errno module.
In-reply-to: <87vcbzoxp8.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83a9tboxdm.fsf@gnu.org>
References: <1355756839-11337-1-git-send-email-brobecker@adacore.com> <1355756839-11337-2-git-send-email-brobecker@adacore.com> <20121218060719.GD3273@adacore.com> <87r4mns49t.fsf@fleche.redhat.com> <20121218165035.GI3273@adacore.com> <87ehins375.fsf@fleche.redhat.com> <20121218181104.GM3273@adacore.com> <87r4mnqk90.fsf@fleche.redhat.com> <83hanjp3we.fsf@gnu.org> <87vcbzoxp8.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00665.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Cc: brobecker@adacore.com, gdb-patches@sourceware.org
> Date: Tue, 18 Dec 2012 14:30:11 -0700
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> How about
> Eli> 3. Test for either ENOENT or EILSEQ where we now test for EILSEQ.
> Eli> ?
> 
> It is tempting but I think it exposes us to libiconv's internals too
> much.  That is, if libiconv changes its choice here, and we are using
> the gnulib EILSEQ, then gdb would start doing the wrong thing.

How about limiting that to known versions of libiconv, then?

I mean, I agree that this all is kludgey, but the whole issue is a
mess.  A library should not define a global symbol, it should only
define symbols for its own private use.