Re: [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate)

[Nick Alcock <nick.alcock@oracle.com>]

On 30 May 2019, Kamil Rytarowski stated:

> On 29.05.2019 23:45, Nick Alcock wrote:
>> I can, however, add backward-compatibility code to dynamically upgrade
>> the old CTF format to the new one at open time, if this seems to be
>> useful. (It's not too different from our format v1). I'm just skeptical
>> that it *is* useful, since CTF info is mostly found in OS kernels so
>> far, and is in a differently-named section.
>> 
>
> We build every binary on NetBSD with CTF and it is used by DTrace.

Ooh, the half-written userspace CTF stuff got finished? That seems...
interesting.

(OK, it looks like I need to add v1 support, so GDB can use it, and
presumably search .SUNW_ctf for CTF sections too. I'll do that after the
next round of format adjustments, since that will include a
refactoring which will among other things make the dynamic upgrading
code a lot easier to maintain when it has lots of divergent formats to
deal with.)

> However there is still DWARF available always so it's not a big problem,
> at least in the default environment.

Hey, if NetBSD can benefit *already* if I just do a few simple bits of
work, it should do so :)

> After an attempt to apply the patch and manual fixups of rejected chunks
> (patch seems to be malformed in the inlined form),

Strange. I'll attach from now on, or send through a known-not-corruptive
mailserver as nix@esperi.org.uk or something.

(But thanks for the report! I think that means we have all known
breakages fixed.)