From: Nick Alcock <nix@esperi.org.uk>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate
Date: Wed, 29 May 2019 16:04:00 -0000 [thread overview]
Message-ID: <87woi9458f.fsf@esperi.org.uk> (raw)
In-Reply-To: <yddr28ha7e4.fsf@CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's message of "Wed, 29 May 2019 12:21:07 +0200")
On 29 May 2019, Rainer Orth told this:
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c: In function 'ctf_arc_bufopen':
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c:320:33: warning: comparison is always true due to limited range of data type [-Wtype-limits]
> 320 | if (le64toh (arc->ctfa_magic) != CTFA_MAGIC)
> | ^~
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c: In function 'ctf_arc_open_internal':
> /vol/src/gnu/gdb/hg/master/local/libctf/ctf-archive.c:357:33: warning: comparison is always true due to limited range of data type [-Wtype-limits]
> 357 | if (le64toh (arc->ctfa_magic) != CTFA_MAGIC)
*Thank* you for this. This revealed significant signedness problems on
32-bit platforms with long <= 32 bits in length, all of which I have now
crushed, to the net benefit of the codebase. :)
Running tests and writing changelogs now.
next prev parent reply other threads:[~2019-05-29 16:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 0:02 gdb-buildbot
2019-05-29 0:02 ` Breakage on builder Solaris11-sparcv9-m64, revision 0e65dfbaf3a0299e4837216a103c28625d4b4f1d gdb-buildbot
2019-05-29 1:34 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
2019-05-29 2:16 ` Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate Simon Marchi
2019-05-29 10:21 ` Rainer Orth
2019-05-29 12:46 ` Nix
2019-05-29 13:14 ` Andreas Schwab
2019-05-29 13:38 ` Rainer Orth
2019-05-29 14:18 ` Nick Alcock
2019-05-29 16:33 ` [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate) Nick Alcock
2019-05-29 18:22 ` Rainer Orth
2019-05-29 20:08 ` Nick Alcock
2019-05-29 20:34 ` Kamil Rytarowski
2019-05-29 21:46 ` Nick Alcock
2019-05-30 0:54 ` Sergio Durigan Junior
2019-05-30 7:14 ` Kamil Rytarowski
2019-05-30 9:35 ` Nick Alcock
2019-05-29 16:04 ` Nick Alcock [this message]
2019-05-29 4:26 ` Breakage on builder NetBSD-x86_64-m64, revision 0e65dfbaf3a0299e4837216a103c28625d4b4f1d gdb-buildbot
2019-05-29 5:51 ` Kamil Rytarowski
2019-05-29 12:51 ` Nick Alcock
2019-05-29 23:31 ` Breakage on builder Fedora-x86_64-w64-mingw32, " gdb-buildbot
2019-05-30 0:13 ` Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woi9458f.fsf@esperi.org.uk \
--to=nix@esperi.org.uk \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox