From: Kamil Rytarowski <n54@gmx.com>
To: Nick Alcock <nick.alcock@oracle.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Simon Marchi <simark@simark.ca>,
gdb-buildbot@sergiodj.net, gdb-patches@sourceware.org,
binutils@sourceware.org
Subject: Re: [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate)
Date: Wed, 29 May 2019 20:34:00 -0000 [thread overview]
Message-ID: <07f014db-d2ff-f2ec-9217-ca672d07cafb@gmx.com> (raw)
In-Reply-To: <87lfyp43w8.fsf_-_@esperi.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 2343 bytes --]
On 29.05.2019 18:33, Nick Alcock wrote:
> On 29 May 2019, Rainer Orth stated:
>
>> Nix <nix@esperi.org.uk> writes:
>>> I stripped almost all of these out, but it looks like one single one
>>> survived. It is gone now.
>>
>> Thanks.
>
> If you'd like to try the entirely unreviewed patch I'm trying out (works
> for me on x86_64-pc-linux-gnu, i686-pc-linux-gnu, mingw, Solaris), here
> it is:
>
I wanted to check this patch on NetBSD but it does not apply for me for
some reason (I've used the original source of the mail as a patch).
Is it safe to use this off64_t define? Won't there be issues with off_t
that is 64-bit on NetBSD and 32-bit on some other OSs? NetBSD uses the
libctf stack from FreeBSD/SunOS for DTrace, will that be compatible with
this GDB code? Keeping CTF support is not the highest priority for us,
as we ship with DWARF.. but compatibility is good.
Feel free to apply this patch and it will be checked with the buildbot node.
$ cat /tmp/1.x |gpatch -p1
patching file include/ChangeLog
patching file include/ctf-api.h
patching file libctf/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file libctf/Makefile.am
patching file libctf/Makefile.in
patching file libctf/aclocal.m4
patching file libctf/config.h.in
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 15 (offset -3 lines).
Hunk #3 succeeded at 94 (offset -3 lines).
1 out of 3 hunks FAILED -- saving rejects to file libctf/config.h.in.rej
patching file libctf/configure
Hunk #5 FAILED at 6139.
Hunk #6 succeeded at 6082 with fuzz 2 (offset -108 lines).
Hunk #7 succeeded at 6340 (offset -108 lines).
Hunk #8 succeeded at 6500 (offset -108 lines).
1 out of 8 hunks FAILED -- saving rejects to file libctf/configure.rej
patching file libctf/configure.ac
Hunk #1 FAILED at 56.
Hunk #2 FAILED at 86.
2 out of 2 hunks FAILED -- saving rejects to file libctf/configure.ac.rej
patching file libctf/ctf-archive.c
patching file libctf/ctf-create.c
patching file libctf/ctf-decls.h
patching file libctf/ctf-dump.c
patching file libctf/ctf-endian.h
patching file libctf/ctf-impl.h
patching file libctf/ctf-labels.c
patching file libctf/ctf-lookup.c
patching file libctf/ctf-open.c
patching file libctf/ctf-types.c
patching file libctf/ctf-util.c
patching file libctf/qsort_r.c
patching file libctf/swap.h
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-29 20:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 0:02 Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate gdb-buildbot
2019-05-29 0:02 ` Breakage on builder Solaris11-sparcv9-m64, revision 0e65dfbaf3a0299e4837216a103c28625d4b4f1d gdb-buildbot
2019-05-29 1:34 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
2019-05-29 2:16 ` Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate Simon Marchi
2019-05-29 10:21 ` Rainer Orth
2019-05-29 12:46 ` Nix
2019-05-29 13:14 ` Andreas Schwab
2019-05-29 13:38 ` Rainer Orth
2019-05-29 14:18 ` Nick Alcock
2019-05-29 16:33 ` [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate) Nick Alcock
2019-05-29 18:22 ` Rainer Orth
2019-05-29 20:08 ` Nick Alcock
2019-05-29 20:34 ` Kamil Rytarowski [this message]
2019-05-29 21:46 ` Nick Alcock
2019-05-30 0:54 ` Sergio Durigan Junior
2019-05-30 7:14 ` Kamil Rytarowski
2019-05-30 9:35 ` Nick Alcock
2019-05-29 16:04 ` Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate Nick Alcock
2019-05-29 4:26 ` Breakage on builder NetBSD-x86_64-m64, revision 0e65dfbaf3a0299e4837216a103c28625d4b4f1d gdb-buildbot
2019-05-29 5:51 ` Kamil Rytarowski
2019-05-29 12:51 ` Nick Alcock
2019-05-29 23:31 ` Breakage on builder Fedora-x86_64-w64-mingw32, " gdb-buildbot
2019-05-30 0:13 ` Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f014db-d2ff-f2ec-9217-ca672d07cafb@gmx.com \
--to=n54@gmx.com \
--cc=binutils@sourceware.org \
--cc=gdb-buildbot@sergiodj.net \
--cc=gdb-patches@sourceware.org \
--cc=nick.alcock@oracle.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox