From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7446 invoked by alias); 29 May 2019 20:34:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7230 invoked by uid 89); 29 May 2019 20:34:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=6340 X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.15.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 20:34:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1559162091; bh=1rFTCVNnTw8mA2Jp83/DADyYZP7qBkQ3+FytuTt6oBM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=KBdo6SzLImgFmrJJi1yU14GeZxGG0PsdmuWWqVuOtZ9K6iamwjp2UOIXEDiV6y22R QX5Ac4A0Jb6HeIX3uecfiEfA+2X1GJb6zU3slX4HrT+yd+w+rHxHWqn3rVODfqfo21 DgTCAFn25msbUDW+jtYCVglCbPoucNlAYeDUhyIg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.71.135.231]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MIMfW-1hQZIv2Fvw-00ELCE; Wed, 29 May 2019 22:21:41 +0200 Subject: Re: [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate) To: Nick Alcock , Rainer Orth Cc: Simon Marchi , gdb-buildbot@sergiodj.net, gdb-patches@sourceware.org, binutils@sourceware.org References: <0e65dfbaf3a0299e4837216a103c28625d4b4f1d-master-breakage@gdb-build> <87r28h5sz0.fsf@esperi.org.uk> <87lfyp43w8.fsf_-_@esperi.org.uk> From: Kamil Rytarowski Openpgp: preference=signencrypt Message-ID: <07f014db-d2ff-f2ec-9217-ca672d07cafb@gmx.com> Date: Wed, 29 May 2019 20:34:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <87lfyp43w8.fsf_-_@esperi.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7FwKHIBdehyleoRZMPgU00o7FSHdnn8IO" X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00661.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7FwKHIBdehyleoRZMPgU00o7FSHdnn8IO Content-Type: multipart/mixed; boundary="5yvmu3ubntLDHjSsOOhOH1qwm7I7i4LRf"; protected-headers="v1" From: Kamil Rytarowski To: Nick Alcock , Rainer Orth Cc: Simon Marchi , gdb-buildbot@sergiodj.net, gdb-patches@sourceware.org, binutils@sourceware.org Message-ID: <07f014db-d2ff-f2ec-9217-ca672d07cafb@gmx.com> Subject: Re: [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate) References: <0e65dfbaf3a0299e4837216a103c28625d4b4f1d-master-breakage@gdb-build> <87r28h5sz0.fsf@esperi.org.uk> <87lfyp43w8.fsf_-_@esperi.org.uk> In-Reply-To: <87lfyp43w8.fsf_-_@esperi.org.uk> --5yvmu3ubntLDHjSsOOhOH1qwm7I7i4LRf Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 2287 On 29.05.2019 18:33, Nick Alcock wrote: > On 29 May 2019, Rainer Orth stated: >=20 >> Nix writes: >>> I stripped almost all of these out, but it looks like one single one >>> survived. It is gone now. >> >> Thanks. >=20 > If you'd like to try the entirely unreviewed patch I'm trying out (works > for me on x86_64-pc-linux-gnu, i686-pc-linux-gnu, mingw, Solaris), here > it is: >=20 I wanted to check this patch on NetBSD but it does not apply for me for some reason (I've used the original source of the mail as a patch). Is it safe to use this off64_t define? Won't there be issues with off_t that is 64-bit on NetBSD and 32-bit on some other OSs? NetBSD uses the libctf stack from FreeBSD/SunOS for DTrace, will that be compatible with this GDB code? Keeping CTF support is not the highest priority for us, as we ship with DWARF.. but compatibility is good. Feel free to apply this patch and it will be checked with the buildbot node. $ cat /tmp/1.x |gpatch -p1 patching file include/ChangeLog patching file include/ctf-api.h patching file libctf/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file libctf/Makefile.am patching file libctf/Makefile.in patching file libctf/aclocal.m4 patching file libctf/config.h.in Hunk #1 FAILED at 1. Hunk #2 succeeded at 15 (offset -3 lines). Hunk #3 succeeded at 94 (offset -3 lines). 1 out of 3 hunks FAILED -- saving rejects to file libctf/config.h.in.rej patching file libctf/configure Hunk #5 FAILED at 6139. Hunk #6 succeeded at 6082 with fuzz 2 (offset -108 lines). Hunk #7 succeeded at 6340 (offset -108 lines). Hunk #8 succeeded at 6500 (offset -108 lines). 1 out of 8 hunks FAILED -- saving rejects to file libctf/configure.rej patching file libctf/configure.ac Hunk #1 FAILED at 56. Hunk #2 FAILED at 86. 2 out of 2 hunks FAILED -- saving rejects to file libctf/configure.ac.rej patching file libctf/ctf-archive.c patching file libctf/ctf-create.c patching file libctf/ctf-decls.h patching file libctf/ctf-dump.c patching file libctf/ctf-endian.h patching file libctf/ctf-impl.h patching file libctf/ctf-labels.c patching file libctf/ctf-lookup.c patching file libctf/ctf-open.c patching file libctf/ctf-types.c patching file libctf/ctf-util.c patching file libctf/qsort_r.c patching file libctf/swap.h --5yvmu3ubntLDHjSsOOhOH1qwm7I7i4LRf-- --7FwKHIBdehyleoRZMPgU00o7FSHdnn8IO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAlzu6e0ACgkQS7MI6bAu dmy1/g//TITBeOrW+5Qiw0QLv26in+igb2l2waSY6+mA3RQMrkRLiDd5fLpCJ5Jg a1xEzVn+7uf5Dd96RcsCxNdgwjHH9qFEtiHJfNpfcZ8/JkzPq73Lzz92HX9NESnD Gap/2/RAw3+fBm7QwiB0tQMlGNyg6kKG+U/zhuMkXohWcVjFbWW61Rwz9bysTbqz 19i5cqapUAMCSnb7wNNj6GO71MiNkYXD1gY34ZTKv0I54WCt6rpKMKJOHuWYErH9 4oBGxF7P5w5Sl19Rd/wnCwP/+IQIwcLRvpzfmU1ij0Aq53nqaQe5EPF2cqKOM9r1 ljSRqSv3T/iGjYrmzRZCjNE79QdCCFdJH1Kwu3Uj3PSecL/KT+ssJnfpJKWX4SIX qY8+HKm5uOP+Pz683SRI2kceoKgDXhI4KkQrPjds6oK2ZxFRtghjMO4k2bQhGVCq TLKpslsPZull3nwUJrUOML2vymh+qUgQpgopBJpIhKM56ldt1v3rWTFCXjtXNSnX w3ENYL8nE+VibI+dHZKu0atZfAO+6fGb5HYp9IMdlbLIswI3+pemXdRWc6NiTM3g 7Vq5+wVH8nwthTeLHWDe9W4qWKLvR52NVYSB6kgpvIvBDj9DKzP73ekieqNe+rmk eO/pCqGubxEXKoYy6eu+W7v7Fr7o8AG37OWI0fE5oeSsXVFlE8k= =6YNL -----END PGP SIGNATURE----- --7FwKHIBdehyleoRZMPgU00o7FSHdnn8IO--