From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33897 invoked by alias); 30 May 2019 09:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33882 invoked by uid 89); 30 May 2019 09:35:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy=H*i:sk:60d8703, H*f:sk:60d8703 X-HELO: userp2130.oracle.com Received: from userp2130.oracle.com (HELO userp2130.oracle.com) (156.151.31.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 May 2019 09:35:29 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U9SxuC115874; Thu, 30 May 2019 09:34:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=NvPDvCdiJaa38j4v92HCG+/Dy/AJgsYnKuJ79InzlNo=; b=M/P/uMJkdM+Pb/pZj/yu4TMgVg2hwBHk8X+CzvkB4A48NBKXEwKJxii3C8YKqqxHLAsR 7f6UudgsK1qgD8CdoxNCsXnF07oULvpd4pD2ud5fbm8Gk1BthVj19bwLt+yDiFiLJ3tj r4K4T0kPaNtbKSMzydIixv8px1bwYd3kf7+wvbRQy2Si/f0gzo21J4Cm8wJgQ6fAN7bx /h31G64fWXFCm7J70tj0R5wvDYfj8onc6gBkWVO9+XnKx/xxn4SxuEoMtaSVHAMOplWq vOxhfG7aiSXnI3cZG/GyDe8q0HXp6MwWqDAQ39wa4AtL/FybnhJzA82OF1k7/2yl7LS3 1w== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2spw4tq0ta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 09:34:58 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U9XO3F103526; Thu, 30 May 2019 09:34:57 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2ss1fnydxs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 09:34:57 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4U9YlmF005335; Thu, 30 May 2019 09:34:48 GMT Received: from loom (/81.187.191.129) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 30 May 2019 02:34:47 -0700 From: Nick Alcock To: Kamil Rytarowski Cc: Rainer Orth , Simon Marchi , Nick Clifton , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate) References: <0e65dfbaf3a0299e4837216a103c28625d4b4f1d-master-breakage@gdb-build> <87r28h5sz0.fsf@esperi.org.uk> <87lfyp43w8.fsf_-_@esperi.org.uk> <07f014db-d2ff-f2ec-9217-ca672d07cafb@gmx.com> <87d0k13pf4.fsf@esperi.org.uk> <60d87039-3084-6d56-3de6-8a29a3d8591f@gmx.com> Date: Thu, 30 May 2019 09:35:00 -0000 In-Reply-To: <60d87039-3084-6d56-3de6-8a29a3d8591f@gmx.com> (Kamil Rytarowski's message of "Thu, 30 May 2019 09:09:52 +0200") Message-ID: <87r28g2sln.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00678.txt.bz2 On 30 May 2019, Kamil Rytarowski stated: > On 29.05.2019 23:45, Nick Alcock wrote: >> I can, however, add backward-compatibility code to dynamically upgrade >> the old CTF format to the new one at open time, if this seems to be >> useful. (It's not too different from our format v1). I'm just skeptical >> that it *is* useful, since CTF info is mostly found in OS kernels so >> far, and is in a differently-named section. >> > > We build every binary on NetBSD with CTF and it is used by DTrace. Ooh, the half-written userspace CTF stuff got finished? That seems... interesting. (OK, it looks like I need to add v1 support, so GDB can use it, and presumably search .SUNW_ctf for CTF sections too. I'll do that after the next round of format adjustments, since that will include a refactoring which will among other things make the dynamic upgrading code a lot easier to maintain when it has lots of divergent formats to deal with.) > However there is still DWARF available always so it's not a big problem, > at least in the default environment. Hey, if NetBSD can benefit *already* if I just do a few simple bits of work, it should do so :) > After an attempt to apply the patch and manual fixups of rejected chunks > (patch seems to be malformed in the inlined form), Strange. I'll attach from now on, or send through a known-not-corruptive mailserver as nix@esperi.org.uk or something. (But thanks for the report! I think that means we have all known breakages fixed.)