Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR 12707
Date: Thu, 17 Jan 2013 21:25:00 -0000	[thread overview]
Message-ID: <87pq13biy8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130115172149.GA21127@host2.jankratochvil.net> (Jan	Kratochvil's message of "Tue, 15 Jan 2013 18:21:49 +0100")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Tom> Second, I had to change cmpd-minsyms.exp to account for the symtab.c
Tom> change, which in turn was required to align symbol_find_demangled_name
Tom> with what dwarf2read.c is doing.

Jan> Yes, this is a problem I faced when thinking about fixing this issue:

Jan> (gdb) b int GDB<char>::even_harder<int>(char)
Jan> Function "int GDB<char>::even_harder<int>(char)" not defined.
Jan> Make breakpoint pending on future shared library load? (y or [n]) 

Jan> I find "int GDB<char>::even_harder<int>(char)" to be a valid (or at
Jan> least also valid) demangled name for that function so I believe GDB
Jan> should know that name.

I agree in principle, but I think the current approach to doing this is
at least odd, and probably unintentional and incorrect.

Right now, minsyms have the return type in their demangled name, but
other symbols do not.

This means that the above could possibly work on an out-of-line
instance, but never on an inline instance.  In a large program this
would mean missing some breakpoint locations.

Changing other symbols to include the return type also seems difficult.

The proposed change means that a breakpoint could still be set, just not
including the return type.

Tom


  reply	other threads:[~2013-01-17 21:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 19:31 Tom Tromey
2013-01-15 15:12 ` Pedro Alves
2013-01-15 15:32   ` Tom Tromey
2013-01-15 16:59 ` Jan Kratochvil
2013-01-15 17:05   ` Tom Tromey
2013-01-15 17:22 ` Jan Kratochvil
2013-01-17 21:25   ` Tom Tromey [this message]
2013-01-17 21:54     ` Jan Kratochvil
2013-01-17 21:59       ` Tom Tromey
2013-01-17 22:04         ` Jan Kratochvil
2013-01-17 22:33           ` Jan Kratochvil
2013-01-18 14:31           ` Tom Tromey
2013-01-18 14:35             ` Jan Kratochvil
2013-01-18 15:04               ` Tom Tromey
2013-01-18 15:33                 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pq13biy8.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox