From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25681 invoked by alias); 17 Jan 2013 21:25:48 -0000 Received: (qmail 25668 invoked by uid 22791); 17 Jan 2013 21:25:46 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Jan 2013 21:25:37 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HLPaLm027564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jan 2013 16:25:36 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0HLPZjh008426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 17 Jan 2013 16:25:36 -0500 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: RFC: fix PR 12707 References: <87r4lno936.fsf@fleche.redhat.com> <20130115172149.GA21127@host2.jankratochvil.net> Date: Thu, 17 Jan 2013 21:25:00 -0000 In-Reply-To: <20130115172149.GA21127@host2.jankratochvil.net> (Jan Kratochvil's message of "Tue, 15 Jan 2013 18:21:49 +0100") Message-ID: <87pq13biy8.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00380.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Tom> Second, I had to change cmpd-minsyms.exp to account for the symtab.c Tom> change, which in turn was required to align symbol_find_demangled_name Tom> with what dwarf2read.c is doing. Jan> Yes, this is a problem I faced when thinking about fixing this issue: Jan> (gdb) b int GDB::even_harder(char) Jan> Function "int GDB::even_harder(char)" not defined. Jan> Make breakpoint pending on future shared library load? (y or [n]) Jan> I find "int GDB::even_harder(char)" to be a valid (or at Jan> least also valid) demangled name for that function so I believe GDB Jan> should know that name. I agree in principle, but I think the current approach to doing this is at least odd, and probably unintentional and incorrect. Right now, minsyms have the return type in their demangled name, but other symbols do not. This means that the above could possibly work on an out-of-line instance, but never on an inline instance. In a large program this would mean missing some breakpoint locations. Changing other symbols to include the return type also seems difficult. The proposed change means that a breakpoint could still be set, just not including the return type. Tom