Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR 12707
Date: Tue, 15 Jan 2013 15:12:00 -0000	[thread overview]
Message-ID: <50F571E6.1080003@redhat.com> (raw)
In-Reply-To: <87r4lno936.fsf@fleche.redhat.com>

No comments on the patch itself.

On 01/14/2013 07:31 PM, Tom Tromey wrote:
>  # A list of minimal symbol names to check.
> -# Note that GDB<char>::even_harder<int>(char) is quoted and includes
> -# the return type.  This is necessary because this is the demangled name
> -# of the minimal symbol.
> +# Note that GDB<char>::even_harder<int>(char) is quoted.

This caught my eye though.  Is there still a reason for the quoting?
(I don't think I understood the original comment's reasoning
fully either.)

>  set min_syms [list \
>  		  "GDB<int>::operator ==" \
>  		  "GDB<int>::operator==(GDB<int> const&)" \
>  		  "GDB<char>::harder(char)" \
>  		  "GDB<int>::harder(int)" \
> -		  {"int GDB<char>::even_harder<int>(char)"} \
> +		  {"GDB<char>::even_harder<int>(char)"} \
>  		  "GDB<int>::simple()"]

-- 
Pedro Alves


  reply	other threads:[~2013-01-15 15:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 19:31 Tom Tromey
2013-01-15 15:12 ` Pedro Alves [this message]
2013-01-15 15:32   ` Tom Tromey
2013-01-15 16:59 ` Jan Kratochvil
2013-01-15 17:05   ` Tom Tromey
2013-01-15 17:22 ` Jan Kratochvil
2013-01-17 21:25   ` Tom Tromey
2013-01-17 21:54     ` Jan Kratochvil
2013-01-17 21:59       ` Tom Tromey
2013-01-17 22:04         ` Jan Kratochvil
2013-01-17 22:33           ` Jan Kratochvil
2013-01-18 14:31           ` Tom Tromey
2013-01-18 14:35             ` Jan Kratochvil
2013-01-18 15:04               ` Tom Tromey
2013-01-18 15:33                 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F571E6.1080003@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox