Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR 12707
Date: Thu, 17 Jan 2013 21:54:00 -0000	[thread overview]
Message-ID: <20130117215358.GA18048@host2.jankratochvil.net> (raw)
In-Reply-To: <87pq13biy8.fsf@fleche.redhat.com>

On Thu, 17 Jan 2013 22:25:35 +0100, Tom Tromey wrote:
> I agree in principle, but I think the current approach to doing this is
> at least odd, and probably unintentional and incorrect.

I agree but in practice it works.


> Changing other symbols to include the return type also seems difficult.

I do not see why.  There exists no demangled name with the return type
anywhere for normal non-template functions.


> The proposed change means that a breakpoint could still be set, just not
> including the return type.

It cannot be set by copy-pasting the symbol name from nm or similar tools.

The data structures could contain both names - with the return type and
without the return type - so that GDB does match both.


Thanks,
Jan


  reply	other threads:[~2013-01-17 21:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 19:31 Tom Tromey
2013-01-15 15:12 ` Pedro Alves
2013-01-15 15:32   ` Tom Tromey
2013-01-15 16:59 ` Jan Kratochvil
2013-01-15 17:05   ` Tom Tromey
2013-01-15 17:22 ` Jan Kratochvil
2013-01-17 21:25   ` Tom Tromey
2013-01-17 21:54     ` Jan Kratochvil [this message]
2013-01-17 21:59       ` Tom Tromey
2013-01-17 22:04         ` Jan Kratochvil
2013-01-17 22:33           ` Jan Kratochvil
2013-01-18 14:31           ` Tom Tromey
2013-01-18 14:35             ` Jan Kratochvil
2013-01-18 15:04               ` Tom Tromey
2013-01-18 15:33                 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130117215358.GA18048@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox