From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12296 invoked by alias); 15 Jan 2013 15:12:49 -0000 Received: (qmail 12256 invoked by uid 22791); 15 Jan 2013 15:12:48 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 15:12:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0FFCefT030320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 Jan 2013 10:12:40 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0FFCcka005273; Tue, 15 Jan 2013 10:12:39 -0500 Message-ID: <50F571E6.1080003@redhat.com> Date: Tue, 15 Jan 2013 15:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: RFC: fix PR 12707 References: <87r4lno936.fsf@fleche.redhat.com> In-Reply-To: <87r4lno936.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00306.txt.bz2 No comments on the patch itself. On 01/14/2013 07:31 PM, Tom Tromey wrote: > # A list of minimal symbol names to check. > -# Note that GDB::even_harder(char) is quoted and includes > -# the return type. This is necessary because this is the demangled name > -# of the minimal symbol. > +# Note that GDB::even_harder(char) is quoted. This caught my eye though. Is there still a reason for the quoting? (I don't think I understood the original comment's reasoning fully either.) > set min_syms [list \ > "GDB::operator ==" \ > "GDB::operator==(GDB const&)" \ > "GDB::harder(char)" \ > "GDB::harder(int)" \ > - {"int GDB::even_harder(char)"} \ > + {"GDB::even_harder(char)"} \ > "GDB::simple()"] -- Pedro Alves