Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands

[Tom Tromey <tromey@redhat.com>]

>>>>> "Mircea" == Mircea Gherzan <mircea.gherzan@intel.com> writes:

Mircea> They are equivalent to "catch load" and "catch unload" from CLI.
Mircea> Rationale: GUIs might be interested in catching solib load or
Mircea> unload events.

Thanks.

Mircea> +/* Shared helper function (MI and CLI) for creating and installing
Mircea> +   a shared object event catchpoint.  */

Mircea> -static void
Mircea> -catch_load_or_unload (char *arg, int from_tty, int is_load,
Mircea> -		      struct cmd_list_element *command)
Mircea> +void
Mircea> +add_solib_catchpoint (char *arg, int is_load, int is_temp, int enabled)

More documentation for the arguments would be nice.

I wouldn't mind hearing Pedro's thoughts on this change, particularly
the breakpoint part.

Mircea> +  DEF_MI_CMD_MI ("catch-load", mi_cmd_catch_load),
Mircea> +  DEF_MI_CMD_MI ("catch-unload", mi_cmd_catch_unload),

I notice that these don't suppress the async breakpoint notification.

It seems more consistent to me to suppress the notification and then
print the new breakpoint information as the result of this command.
I'm curious to know your rationale for this approach.

Tom