From: Mircea Gherzan <mircea.gherzan@intel.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org, keven.boell@intel.com,
marc.khouzam@ericsson.com, vladimir@codesourcery.com
Subject: Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
Date: Thu, 29 Nov 2012 16:22:00 -0000 [thread overview]
Message-ID: <50B78BBB.1000907@intel.com> (raw)
In-Reply-To: <87obiidfxl.fsf@fleche.redhat.com>
Thanks for your review.
On 27.11.2012 20:05, Tom Tromey wrote:
> I wouldn't mind hearing Pedro's thoughts on this change, particularly
> the breakpoint part.
>
> Mircea> + DEF_MI_CMD_MI ("catch-load", mi_cmd_catch_load),
> Mircea> + DEF_MI_CMD_MI ("catch-unload", mi_cmd_catch_unload),
>
> I notice that these don't suppress the async breakpoint notification.
>
> It seems more consistent to me to suppress the notification and then
> print the new breakpoint information as the result of this command.
This has been fixed in v7 of the series.
Mircea
--
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2012-11-29 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 15:53 Mircea Gherzan
2012-11-27 15:56 ` [PATCH v6 3/3] MI: tests for -catch-load/-catch-unload Mircea Gherzan
2012-11-27 19:09 ` Tom Tromey
2012-11-27 15:56 ` [PATCH v6 2/3] MI: document the -catch-load/-unload commands Mircea Gherzan
2012-11-27 18:06 ` Eli Zaretskii
2012-11-27 19:06 ` [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands Tom Tromey
2012-11-29 16:22 ` Mircea Gherzan [this message]
2012-11-29 21:09 ` Tom Tromey
2012-11-29 22:22 ` Mircea Gherzan
2012-11-30 16:15 ` Tom Tromey
2012-11-30 18:38 ` Tom Tromey
2012-12-03 14:24 ` Mircea Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B78BBB.1000907@intel.com \
--to=mircea.gherzan@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
--cc=marc.khouzam@ericsson.com \
--cc=tromey@redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox