From: Mircea Gherzan <mgherzan@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Mircea Gherzan <mircea.gherzan@intel.com>,
gdb-patches@sourceware.org, keven.boell@intel.com,
marc.khouzam@ericsson.com, vladimir@codesourcery.com
Subject: Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands
Date: Thu, 29 Nov 2012 22:22:00 -0000 [thread overview]
Message-ID: <50B7E033.5050208@gmail.com> (raw)
In-Reply-To: <87ehjc3yn2.fsf@fleche.redhat.com>
Am 29.11.2012 22:08, schrieb Tom Tromey:
>>>>>> "Mircea" == Mircea Gherzan <mircea.gherzan@intel.com> writes:
>
>>> It seems more consistent to me to suppress the notification and then
>>> print the new breakpoint information as the result of this command.
>
> Mircea> This has been fixed in v7 of the series.
>
> There were some other review comments you haven't addressed yet: more
> comments for the one function in breakpoint.c, and possible raciness in
> the test case.
The possible raciness has also been addressed in v7, since no more async
notifications are present: we just use the ^done reply to carry the
catchpoint info. Furthermore, "mi_send_resuming_command" is used now.
I just wanted to collect some feedback regarding the suppression of the
async notifications before sending v8 (hopefully the last iteration).
--
Mircea
next prev parent reply other threads:[~2012-11-29 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 15:53 Mircea Gherzan
2012-11-27 15:56 ` [PATCH v6 3/3] MI: tests for -catch-load/-catch-unload Mircea Gherzan
2012-11-27 19:09 ` Tom Tromey
2012-11-27 15:56 ` [PATCH v6 2/3] MI: document the -catch-load/-unload commands Mircea Gherzan
2012-11-27 18:06 ` Eli Zaretskii
2012-11-27 19:06 ` [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands Tom Tromey
2012-11-29 16:22 ` Mircea Gherzan
2012-11-29 21:09 ` Tom Tromey
2012-11-29 22:22 ` Mircea Gherzan [this message]
2012-11-30 16:15 ` Tom Tromey
2012-11-30 18:38 ` Tom Tromey
2012-12-03 14:24 ` Mircea Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B7E033.5050208@gmail.com \
--to=mgherzan@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
--cc=marc.khouzam@ericsson.com \
--cc=mircea.gherzan@intel.com \
--cc=tromey@redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox