From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21691 invoked by alias); 29 Nov 2012 16:22:57 -0000 Received: (qmail 21664 invoked by uid 22791); 29 Nov 2012 16:22:55 -0000 X-SWARE-Spam-Status: No, hits=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 16:22:48 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 29 Nov 2012 08:22:46 -0800 X-ExtLoop1: 1 Received: from mirceagh-mobl.ger.corp.intel.com (HELO [172.28.205.136]) ([172.28.205.136]) by orsmga001.jf.intel.com with ESMTP; 29 Nov 2012 08:22:20 -0800 Message-ID: <50B78BBB.1000907@intel.com> Date: Thu, 29 Nov 2012 16:22:00 -0000 From: Mircea Gherzan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org, keven.boell@intel.com, marc.khouzam@ericsson.com, vladimir@codesourcery.com Subject: Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands References: <1354031591-20226-1-git-send-email-mircea.gherzan@intel.com> <87obiidfxl.fsf@fleche.redhat.com> In-Reply-To: <87obiidfxl.fsf@fleche.redhat.com> Content-Type: text/plain; charset="iso-8859-1"; format="flowed" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00876.txt.bz2 Thanks for your review. On 27.11.2012 20:05, Tom Tromey wrote: > I wouldn't mind hearing Pedro's thoughts on this change, particularly > the breakpoint part. > > Mircea> + DEF_MI_CMD_MI ("catch-load", mi_cmd_catch_load), > Mircea> + DEF_MI_CMD_MI ("catch-unload", mi_cmd_catch_unload), > > I notice that these don't suppress the async breakpoint notification. > > It seems more consistent to me to suppress the notification and then > print the new breakpoint information as the result of this command. This has been fixed in v7 of the series. Mircea --=20 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter, Hannes Schwadere= r, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052