From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31402 invoked by alias); 27 Nov 2012 19:06:25 -0000 Received: (qmail 31389 invoked by uid 22791); 27 Nov 2012 19:06:23 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Nov 2012 19:06:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qARJ60kO014242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Nov 2012 14:06:01 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qARJ5wsX007628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 27 Nov 2012 14:05:59 -0500 From: Tom Tromey To: Mircea Gherzan Cc: gdb-patches@sourceware.org, keven.boell@intel.com, marc.khouzam@ericsson.com, vladimir@codesourcery.com Subject: Re: [PATCH v6 1/3] MI: add the -catch-load and -catch-unload commands References: <1354031591-20226-1-git-send-email-mircea.gherzan@intel.com> Date: Tue, 27 Nov 2012 19:06:00 -0000 In-Reply-To: <1354031591-20226-1-git-send-email-mircea.gherzan@intel.com> (Mircea Gherzan's message of "Tue, 27 Nov 2012 16:53:09 +0100") Message-ID: <87obiidfxl.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00774.txt.bz2 >>>>> "Mircea" == Mircea Gherzan writes: Mircea> They are equivalent to "catch load" and "catch unload" from CLI. Mircea> Rationale: GUIs might be interested in catching solib load or Mircea> unload events. Thanks. Mircea> +/* Shared helper function (MI and CLI) for creating and installing Mircea> + a shared object event catchpoint. */ Mircea> -static void Mircea> -catch_load_or_unload (char *arg, int from_tty, int is_load, Mircea> - struct cmd_list_element *command) Mircea> +void Mircea> +add_solib_catchpoint (char *arg, int is_load, int is_temp, int enabled) More documentation for the arguments would be nice. I wouldn't mind hearing Pedro's thoughts on this change, particularly the breakpoint part. Mircea> + DEF_MI_CMD_MI ("catch-load", mi_cmd_catch_load), Mircea> + DEF_MI_CMD_MI ("catch-unload", mi_cmd_catch_unload), I notice that these don't suppress the async breakpoint notification. It seems more consistent to me to suppress the notification and then print the new breakpoint information as the result of this command. I'm curious to know your rationale for this approach. Tom