* [PATCH] Fix crash in Ada "catch exception"
@ 2019-09-20 17:40 Tom Tromey
2019-09-20 19:24 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2019-09-20 17:40 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
PR ada/24919 concerns a crash that Tom de Vries noticed when running
the "catch_ex" Ada test case. He sent a test executable and tracked
this down to commit f21c2bd7b7 ("Fix Fortran regression with variables
in nested functions").
Looking at that patch, you can see the obvious error:
- return 0;
+ return true;
Oops! This patch fixes the bug.
Tested on x86-64 Fedora 29.
gdb/ChangeLog
2019-09-20 Tom Tromey <tromey@adacore.com>
PR ada/24919:
* block.c (contained_in): Fix final return value.
---
gdb/ChangeLog | 5 +++++
gdb/block.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/block.c b/gdb/block.c
index ca4dc22cf30..5ba44d47ba7 100644
--- a/gdb/block.c
+++ b/gdb/block.c
@@ -86,7 +86,7 @@ contained_in (const struct block *a, const struct block *b,
}
while (a != NULL);
- return true;
+ return false;
}
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Fix crash in Ada "catch exception"
2019-09-20 17:40 [PATCH] Fix crash in Ada "catch exception" Tom Tromey
@ 2019-09-20 19:24 ` Joel Brobecker
2019-09-20 19:25 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2019-09-20 19:24 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
> PR ada/24919 concerns a crash that Tom de Vries noticed when running
> the "catch_ex" Ada test case. He sent a test executable and tracked
> this down to commit f21c2bd7b7 ("Fix Fortran regression with variables
> in nested functions").
>
> Looking at that patch, you can see the obvious error:
>
> - return 0;
> + return true;
>
> Oops! This patch fixes the bug.
Indeed!
> gdb/ChangeLog
> 2019-09-20 Tom Tromey <tromey@adacore.com>
>
> PR ada/24919:
> * block.c (contained_in): Fix final return value.
Looks good to me, Tom.
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-20 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20 17:40 [PATCH] Fix crash in Ada "catch exception" Tom Tromey
2019-09-20 19:24 ` Joel Brobecker
2019-09-20 19:25 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox