From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-158946-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 79993 invoked by alias); 20 Sep 2019 19:24:55 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 63796 invoked by uid 89); 20 Sep 2019 19:24:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2019 19:24:40 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 9D1A556078;	Fri, 20 Sep 2019 15:24:37 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id QC259I22aN+O; Fri, 20 Sep 2019 15:24:37 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 68C3256075;	Fri, 20 Sep 2019 15:24:37 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id A510085D5C; Fri, 20 Sep 2019 12:24:35 -0700 (PDT)
Date: Fri, 20 Sep 2019 19:24:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash in Ada "catch exception"
Message-ID: <20190920192435.GA21402@adacore.com>
References: <20190920174038.9760-1-tromey@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190920174038.9760-1-tromey@adacore.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-SW-Source: 2019-09/txt/msg00413.txt.bz2

> PR ada/24919 concerns a crash that Tom de Vries noticed when running
> the "catch_ex" Ada test case.  He sent a test executable and tracked
> this down to commit f21c2bd7b7 ("Fix Fortran regression with variables
> in nested functions").
> 
> Looking at that patch, you can see the obvious error:
> 
>     -  return 0;
>     +  return true;
> 
> Oops!  This patch fixes the bug.

Indeed!

> gdb/ChangeLog
> 2019-09-20  Tom Tromey  <tromey@adacore.com>
> 
> 	PR ada/24919:
> 	* block.c (contained_in): Fix final return value.

Looks good to me, Tom.

-- 
Joel