From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash in Ada "catch exception"
Date: Fri, 20 Sep 2019 19:24:00 -0000 [thread overview]
Message-ID: <20190920192435.GA21402@adacore.com> (raw)
In-Reply-To: <20190920174038.9760-1-tromey@adacore.com>
> PR ada/24919 concerns a crash that Tom de Vries noticed when running
> the "catch_ex" Ada test case. He sent a test executable and tracked
> this down to commit f21c2bd7b7 ("Fix Fortran regression with variables
> in nested functions").
>
> Looking at that patch, you can see the obvious error:
>
> - return 0;
> + return true;
>
> Oops! This patch fixes the bug.
Indeed!
> gdb/ChangeLog
> 2019-09-20 Tom Tromey <tromey@adacore.com>
>
> PR ada/24919:
> * block.c (contained_in): Fix final return value.
Looks good to me, Tom.
--
Joel
next prev parent reply other threads:[~2019-09-20 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 17:40 Tom Tromey
2019-09-20 19:24 ` Joel Brobecker [this message]
2019-09-20 19:25 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920192435.GA21402@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox