Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Ciaran Woodward <ciaranwoodward@xmos.com>
Cc: Daniel Fellows <daniel.fellows@arm.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	 "tom@tromey.com" <tom@tromey.com>, "nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH 1/1] gdb/tui: Fix build for older ncurses
Date: Thu, 30 Jul 2026 10:18:07 -0600	[thread overview]
Message-ID: <87o6foqwn4.fsf@tromey.com> (raw)
In-Reply-To: <MI3PR09MB8624C424FF3F0BDF7DF0E063B9CB2@MI3PR09MB8624.eurprd09.prod.outlook.com> (Ciaran Woodward's message of "Tue, 28 Jul 2026 13:29:01 +0000")

>>>>> "Ciaran" == Ciaran Woodward <ciaranwoodward@xmos.com> writes:

Ciaran> I'm happy for this fix to be backported, and I'm happy to push the commit
Ciaran> if you aren't able - from my perspective it seems extremely low risk.

Ciaran> I'm not quite sure on the backport process - I assume it needs approval by
Ciaran> a maintainer, at least.

Ciaran> Can any maintainer fill us in?

Yeah, approval is needed.

It is fine to backport; if the cherry-pick is clean you can just
proceed.

I normally "git cherry-pick -x" to provide some link to the original
commit.

You can stick my approval tag in there if you want.
Approved-By: Tom Tromey <tom@tromey.com>

I didn't look in this case but one checklist item is to see if there are
any necessary follow-on commits.

thanks,
Tom

  parent reply	other threads:[~2026-07-30 16:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 18:30 Ciaran Woodward
2025-09-12 15:04 ` Tom Tromey
2025-09-12 17:17   ` Ciaran Woodward
2026-07-27 16:15     ` Daniel Fellows
2026-07-28 13:29       ` Ciaran Woodward
2026-07-28 13:38         ` Daniel Fellows
2026-07-30 16:18         ` Tom Tromey [this message]
2026-07-31 11:28           ` Ciaran Woodward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6foqwn4.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=ciaranwoodward@xmos.com \
    --cc=daniel.fellows@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox